From: David Kamholz Date: Wed, 22 Nov 2006 06:54:10 +0000 (+0000) Subject: revert update() change X-Git-Url: http://git.shadowcat.co.uk/gitweb/gitweb.cgi?a=commitdiff_plain;h=c56897b45d7ca4e70d64bcf251931aaedc04f4b4;p=dbsrgits%2FDBIx-Class-Historic.git revert update() change --- diff --git a/lib/DBIx/Class/Row.pm b/lib/DBIx/Class/Row.pm index 213f3cc..57f883f 100644 --- a/lib/DBIx/Class/Row.pm +++ b/lib/DBIx/Class/Row.pm @@ -110,12 +110,12 @@ required. sub update { my ($self, $upd) = @_; $self->throw_exception( "Not in database" ) unless $self->in_storage; - my $ident_cond = $self->ident_condition; - $self->throw_exception("Cannot safely update a row in a PK-less table") - if ! keys %$ident_cond; $self->set_columns($upd) if $upd; my %to_update = $self->get_dirty_columns; return $self unless keys %to_update; + my $ident_cond = $self->ident_condition; + $self->throw_exception("Cannot safely update a row in a PK-less table") + if ! keys %$ident_cond; my $rows = $self->result_source->storage->update( $self->result_source->from, \%to_update, $ident_cond); if ($rows == 0) {