From: Nigel Metheringham Date: Mon, 27 Oct 2008 21:55:55 +0000 (+0000) Subject: Minor tweaks to RH perf issue stuff following suggestions from ribasushi> X-Git-Url: http://git.shadowcat.co.uk/gitweb/gitweb.cgi?a=commitdiff_plain;h=c13fabce230792388c8c57fb9cd481be65fe3125;p=dbsrgits%2FDBIx-Class-Historic.git Minor tweaks to RH perf issue stuff following suggestions from ribasushi> --- diff --git a/lib/DBIx/Class/Manual/Troubleshooting.pod b/lib/DBIx/Class/Manual/Troubleshooting.pod index cf4d5b8..b870b3b 100644 --- a/lib/DBIx/Class/Manual/Troubleshooting.pod +++ b/lib/DBIx/Class/Manual/Troubleshooting.pod @@ -128,7 +128,7 @@ Now you'll get SQL like this: There is a problem with slow performance of certain DBIx::Class operations using the system perl on some Fedora and Red Hat Enterprise Linux system (as well as their derivative distributions such as Centos, -White Box and Scientific Linix). +White Box and Scientific Linux). Distributions affected include Fedora 5 through to Fedora 8 and RHEL5 upto and including RHEL5 Update 2. Fedora 9 (which uses perl 5.10) has diff --git a/t/99rh_perl_perf_bug.t b/t/99rh_perl_perf_bug.t index 645c115..d075e8f 100644 --- a/t/99rh_perl_perf_bug.t +++ b/t/99rh_perl_perf_bug.t @@ -16,7 +16,7 @@ use DBICTest; # variable # # If these tests fail then please read the section titled -# Perl Performance Issues on Red Hat Systems in +# Perl Performance Issues on Red Hat Systems in # L plan skip_all => @@ -50,7 +50,7 @@ ok( !_possibly_has_bad_overload_performance(), 'Checking not susceptable to bless/overload performance problem' ); my $results = timethese( - 0, + -1, # run for 1 CPU second each { overload => sub { use overload q(<) => sub { }; @@ -68,5 +68,9 @@ my $results = timethese( } ); +# we are OK if there is less than a factor of 2 difference here ok( ( ( $results->{nooverload}->iters / $results->{overload}->iters ) < 2 ), 'Overload/bless performance acceptable' ) +# if the test above failed, look at the section titled +# Perl Performance Issues on Red Hat Systems in +# L \ No newline at end of file