From: Tokuhiro Matsuno <tokuhirom@gp.ath.cx>
Date: Wed, 3 Dec 2008 03:26:08 +0000 (+0000)
Subject: performance tuning
X-Git-Tag: 0.19~136^2~74
X-Git-Url: http://git.shadowcat.co.uk/gitweb/gitweb.cgi?a=commitdiff_plain;h=c12edd9ac9343d9853e4b9ca9f2254336e468ffc;p=gitmo%2FMouse.git

performance tuning
---

diff --git a/lib/Mouse/Meta/Method/Constructor.pm b/lib/Mouse/Meta/Method/Constructor.pm
index b1db7d4..2de3802 100644
--- a/lib/Mouse/Meta/Method/Constructor.pm
+++ b/lib/Mouse/Meta/Method/Constructor.pm
@@ -5,9 +5,10 @@ use warnings;
 sub generate_constructor_method_inline {
     my ($class, $meta) = @_;
 
+    my @attrs = $meta->compute_all_applicable_attributes; # this one is using by evaled code
     my $buildall = $class->_generate_BUILDALL($meta);
     my $buildargs = $class->_generate_BUILDARGS();
-    my $processattrs = $class->_generate_processattrs($meta);
+    my $processattrs = $class->_generate_processattrs($meta, \@attrs);
 
     my $code = <<"...";
     sub {
@@ -29,10 +30,10 @@ sub generate_constructor_method_inline {
 }
 
 sub _generate_processattrs {
-    my ($class, $meta, ) = @_;
-    my @attrs = $meta->compute_all_applicable_attributes;
+    my ($class, $meta, $attrs) = @_;
     my @res;
-    for my $attr (@attrs) {
+    for my $index (0..scalar(@$attrs)-1) {
+        my $attr = $attrs->[$index];
         my $from = $attr->init_arg;
         my $key  = $attr->name;
         my $part1 = do {
@@ -88,7 +89,7 @@ sub _generate_processattrs {
         };
         my $code = <<"...";
             {
-                my \$attr = \$meta->get_attribute('$key');
+                my \$attr = \$attrs[$index];
                 my \$from = '$from';
                 my \$key  = '$key';
                 if (defined(\$from) && exists(\$args->{\$from})) {