From: Jesse Luehrs <doy@tozt.net>
Date: Sun, 3 May 2009 02:35:52 +0000 (-0500)
Subject: don't rely on method meta objects still existing in DEMOLISHALL
X-Git-Tag: 0.78~47
X-Git-Url: http://git.shadowcat.co.uk/gitweb/gitweb.cgi?a=commitdiff_plain;h=c063fc8bfc7d7939942ab8de7f4db9eee3465ed0;p=gitmo%2FMoose.git

don't rely on method meta objects still existing in DEMOLISHALL
---

diff --git a/lib/Moose/Object.pm b/lib/Moose/Object.pm
index 5d29729..61b8dd3 100644
--- a/lib/Moose/Object.pm
+++ b/lib/Moose/Object.pm
@@ -71,14 +71,14 @@ sub DEMOLISHALL {
     my $meta = Class::MOP::class_of($self)
         || Moose::Meta::Class->initialize( ref $self );
 
-    foreach my $method ( $meta->find_all_methods_by_name('DEMOLISH') ) {
-        $meta->throw_error(
-            "Couldn't call DEMOLISH on package $method->{class} because"
-          . " global destruction destroyed it first. Make sure all of"
-          . " your instances of $method->{class} are destroyed before"
-          . " global destruction to fix this."
-        ) if !$method->{code} && $in_global_destruction;
-        $method->{code}->execute($self, $in_global_destruction);
+    # can't just use find_all_methods_by_name here because during global
+    # destruction, the method meta-object may have already been
+    # destroyed
+    foreach my $class ( $meta->linearized_isa ) {
+        no strict 'refs';
+        my $demolish = *{"${class}::DEMOLISH"}{CODE};
+        $self->$demolish($in_global_destruction)
+            if defined $demolish;
     }
 }