From: Peter Rabbitson Date: Fri, 4 Sep 2009 17:17:32 +0000 (+0000) Subject: Dumper follies X-Git-Tag: v0.08111~16 X-Git-Url: http://git.shadowcat.co.uk/gitweb/gitweb.cgi?a=commitdiff_plain;h=bfa46eb523fff8ece9b37a48d17b90510f1c8c52;p=dbsrgits%2FDBIx-Class.git Dumper follies --- diff --git a/t/103many_to_many_warning.t b/t/103many_to_many_warning.t index 37a0472..36d41a8 100644 --- a/t/103many_to_many_warning.t +++ b/t/103many_to_many_warning.t @@ -3,7 +3,6 @@ use warnings; use Test::More; use lib qw(t/lib); -use Data::Dumper; plan tests => 4; my $exp_warn = qr/The many-to-many relationship 'bars' is trying to create/; diff --git a/t/46where_attribute.t b/t/46where_attribute.t index 1c03591..a54adb6 100644 --- a/t/46where_attribute.t +++ b/t/46where_attribute.t @@ -2,7 +2,6 @@ use strict; use warnings; use Test::More; -use Data::Dumper; use lib qw(t/lib); use DBICTest; my $schema = DBICTest->init_schema(); diff --git a/t/76joins.t b/t/76joins.t index 5706dfa..ba87a0a 100644 --- a/t/76joins.t +++ b/t/76joins.t @@ -4,7 +4,6 @@ use warnings; use Test::More; use lib qw(t/lib); use DBICTest; -use Data::Dumper; use DBIC::SqlMakerTest; my $schema = DBICTest->init_schema(); diff --git a/t/83cache.t b/t/83cache.t index 91b226c..2f4c036 100644 --- a/t/83cache.t +++ b/t/83cache.t @@ -74,8 +74,6 @@ $rs = $schema->resultset("Artist")->search( } ); -use Data::Dumper; $Data::Dumper::Deparse = 1; - # start test for prefetch SELECT count $queries = 0; $schema->storage->debug(1); diff --git a/t/count/grouped_pager.t b/t/count/grouped_pager.t index cfe29af..6bb6153 100644 --- a/t/count/grouped_pager.t +++ b/t/count/grouped_pager.t @@ -11,8 +11,6 @@ plan tests => 7; my $schema = DBICTest->init_schema(); -use Data::Dumper; - # add 2 extra artists $schema->populate ('Artist', [ [qw/name/], diff --git a/t/count/in_subquery.t b/t/count/in_subquery.t index 1275c1e..e435640 100644 --- a/t/count/in_subquery.t +++ b/t/count/in_subquery.t @@ -3,8 +3,6 @@ use strict; use warnings; -use Data::Dumper; - use Test::More; plan ( tests => 1 ); diff --git a/t/inflate/serialize.t b/t/inflate/serialize.t index e9b51df..49cf695 100644 --- a/t/inflate/serialize.t +++ b/t/inflate/serialize.t @@ -7,8 +7,6 @@ use DBICTest; my $schema = DBICTest->init_schema(); -use Data::Dumper; - my @serializers = ( { module => 'YAML.pm', inflater => sub { YAML::Load (shift) }, diff --git a/t/prefetch/attrs_untouched.t b/t/prefetch/attrs_untouched.t index 41ad883..ecb29dd 100644 --- a/t/prefetch/attrs_untouched.t +++ b/t/prefetch/attrs_untouched.t @@ -4,7 +4,9 @@ use Test::More; use Test::Exception; use lib qw(t/lib); use DBICTest; + use Data::Dumper; +$Data::Dumper::Sortkeys = 1; my $schema = DBICTest->init_schema(); diff --git a/t/prefetch/standard.t b/t/prefetch/standard.t index 72426ee..7980da3 100644 --- a/t/prefetch/standard.t +++ b/t/prefetch/standard.t @@ -5,7 +5,6 @@ use Test::More; use Test::Exception; use lib qw(t/lib); use DBICTest; -use Data::Dumper; use IO::File; my $schema = DBICTest->init_schema(); @@ -20,8 +19,6 @@ $schema->storage->debug(1); my $search = { 'artist.name' => 'Caterwauler McCrae' }; my $attr = { prefetch => [ qw/artist liner_notes/ ], order_by => 'me.cdid' }; -my $search_str = Dumper($search); -my $attr_str = Dumper($attr); my $rs = $schema->resultset("CD")->search($search, $attr); my @cd = $rs->all; diff --git a/t/resultset/as_query.t b/t/resultset/as_query.t index 9cf2e36..beca3f9 100644 --- a/t/resultset/as_query.t +++ b/t/resultset/as_query.t @@ -3,8 +3,6 @@ use strict; use warnings FATAL => 'all'; -use Data::Dumper; - use Test::More; plan ( tests => 5 ); diff --git a/t/search/preserve_original_rs.t b/t/search/preserve_original_rs.t index d628e9b..8ba6d18 100644 --- a/t/search/preserve_original_rs.t +++ b/t/search/preserve_original_rs.t @@ -8,7 +8,10 @@ use lib qw(t/lib); use DBIC::SqlMakerTest; use DBIC::DebugObj; use DBICTest; + +# use Data::Dumper comparisons to avoid mesing with coderefs use Data::Dumper; +$Data::Dumper::Sortkeys = 1; my $schema = DBICTest->init_schema(); diff --git a/t/search/subquery.t b/t/search/subquery.t index 1f72b07..5afc9f3 100644 --- a/t/search/subquery.t +++ b/t/search/subquery.t @@ -3,11 +3,8 @@ use strict; use warnings; -use Data::Dumper; - use Test::More; - use lib qw(t/lib); use DBICTest; use DBIC::SqlMakerTest; diff --git a/t/storage/ping_count.t b/t/storage/ping_count.t index 07659cb..ed461cd 100644 --- a/t/storage/ping_count.t +++ b/t/storage/ping_count.t @@ -4,7 +4,6 @@ use warnings; use Test::More; use lib qw(t/lib); use DBICTest; -use Data::Dumper; use DBIC::SqlMakerTest; my $ping_count = 0;