From: Peter Rabbitson <ribasushi@cpan.org>
Date: Mon, 18 May 2009 12:05:31 +0000 (+0000)
Subject: Add a comment about a small resolve_join omission
X-Git-Url: http://git.shadowcat.co.uk/gitweb/gitweb.cgi?a=commitdiff_plain;h=bf282e60b7158975dda500d7584c4acc3d298bf3;p=dbsrgits%2FDBIx-Class-Historic.git

Add a comment about a small resolve_join omission
---

diff --git a/lib/DBIx/Class/ResultSource.pm b/lib/DBIx/Class/ResultSource.pm
index f9e8654..97e45fa 100644
--- a/lib/DBIx/Class/ResultSource.pm
+++ b/lib/DBIx/Class/ResultSource.pm
@@ -1092,7 +1092,13 @@ sub resolve_join {
     unless $seen;
 
   $force_left ||= { force => 0 };
-  $jpath ||= [];
+
+  # This isn't quite right, we should actually dive into $seen and reconstruct
+  # the entire path (the reference entry point would be the join conditional
+  # with depth == current_depth - 1. At this point however nothing depends on
+  # having the entire path, transcending related_resultset, so just leave it
+  # as is, hairy enough already.
+  $jpath ||= [];  
 
   if (ref $join eq 'ARRAY') {
     return