From: Jarkko Hietaniemi Date: Mon, 27 Nov 2000 00:49:27 +0000 (+0000) Subject: Retract #7863. It makes more sense not to taint formatted output, X-Git-Url: http://git.shadowcat.co.uk/gitweb/gitweb.cgi?a=commitdiff_plain;h=bda0f7a595ddfa8fb68d6c9db743f2822d220e6d;p=p5sagit%2Fp5-mst-13.2.git Retract #7863. It makes more sense not to taint formatted output, not even by sprintf(). p4raw-id: //depot/perl@7875 --- diff --git a/sv.c b/sv.c index be1947a..a6e453f 100644 --- a/sv.c +++ b/sv.c @@ -6623,11 +6623,10 @@ Perl_sv_vcatpvfn(pTHX_ SV *sv, const char *pat, STRLEN patlen, va_list *args, SV *--eptr = '#'; *--eptr = '%'; + /* No taint. Otherwise we are in the strange + * situaiton where printf() taints but print($float) doesn't. + * --jhi */ (void)sprintf(PL_efloatbuf, eptr, nv); -#ifdef USE_LOCALE_NUMERIC - if ((PL_hints & HINT_LOCALE) && maybe_tainted) - *maybe_tainted = TRUE; -#endif eptr = PL_efloatbuf; elen = strlen(PL_efloatbuf);