From: Matt S Trout Date: Wed, 19 Apr 2006 20:47:36 +0000 (+0000) Subject: fixup for Dumper brain damage X-Git-Url: http://git.shadowcat.co.uk/gitweb/gitweb.cgi?a=commitdiff_plain;h=bd054cb4b55b857c1fd3192007f5448bf3687c30;p=dbsrgits%2FDBIx-Class-Historic.git fixup for Dumper brain damage --- diff --git a/Changes b/Changes index c736374..e9cdf80 100644 --- a/Changes +++ b/Changes @@ -1,6 +1,7 @@ Revision history for DBIx::Class 0.06002 + - fix to Dumper-induced hash iteration bug - fix to copy() with non-composed resultsource - fix to ->search without args to clone rs but maintain cache - grab $self->dbh once per function in Storage::DBI diff --git a/lib/DBIx/Class/ResultSource.pm b/lib/DBIx/Class/ResultSource.pm index 714353d..e54e3fc 100644 --- a/lib/DBIx/Class/ResultSource.pm +++ b/lib/DBIx/Class/ResultSource.pm @@ -508,7 +508,8 @@ sub resolve_condition { #warn %$cond; if (ref $cond eq 'HASH') { my %ret; - while (my ($k, $v) = each %{$cond}) { + foreach my $k (keys %{$cond}) { + my $v = $cond->{$k}; # XXX should probably check these are valid columns $k =~ s/^foreign\.// || $self->throw_exception("Invalid rel cond key ${k}");