From: Nicholas Clark <nick@ccl4.org>
Date: Mon, 16 May 2005 15:01:48 +0000 (+0000)
Subject: Assuming that everything with 0x40000000 is SVpad_TYPED is bogus.
X-Git-Url: http://git.shadowcat.co.uk/gitweb/gitweb.cgi?a=commitdiff_plain;h=bce8f4120e2273696708e81ef6c1d919b324fb00;p=p5sagit%2Fp5-mst-13.2.git

Assuming that everything with 0x40000000 is SVpad_TYPED is bogus.

p4raw-id: //depot/perl@24480
---

diff --git a/sv.c b/sv.c
index 06e23ea..90572f1 100644
--- a/sv.c
+++ b/sv.c
@@ -1937,6 +1937,10 @@ Perl_sv_upgrade(pTHX_ register SV *sv, U32 mt)
 	   there's no way that it can be safely upgraded, because perl.c
 	   expects to Safefree(SvANY(PL_mess_sv))  */
 	assert(sv != PL_mess_sv);
+	/* This flag bit is used to mean other things in other scalar types.
+	   Given that it only has meaning inside the pad, it shouldn't be set
+	   on anything that can get upgraded.  */
+	assert((SvFLAGS(sv) & SVpad_TYPED) == 0);
 	pv	= SvPVX(sv);
 	cur	= SvCUR(sv);
 	len	= SvLEN(sv);
@@ -5975,7 +5979,7 @@ Perl_sv_clear(pTHX_ register SV *sv)
     if (SvTYPE(sv) >= SVt_PVMG) {
     	if (SvMAGIC(sv))
 	    mg_free(sv);
-	if (SvFLAGS(sv) & SVpad_TYPED)
+	if (SvTYPE(sv) == SVt_PVMG && SvFLAGS(sv) & SVpad_TYPED)
 	    SvREFCNT_dec(SvSTASH(sv));
     }
     stash = NULL;