From: Peter Rabbitson Date: Sun, 10 Apr 2016 08:55:31 +0000 (+0200) Subject: Remove incorrect SKIP for 5.8.1 X-Git-Tag: 0.27~4 X-Git-Url: http://git.shadowcat.co.uk/gitweb/gitweb.cgi?a=commitdiff_plain;h=bc62b4f7af3fe7812e64d6d5389252cde1e2fb9a;p=p5sagit%2Fnamespace-clean.git Remove incorrect SKIP for 5.8.1 The reason this test failed is srictly the construct of the test itself, and not part of namespace::clean's functionality. reqiure() in list-assign context combined with an @INC coderef hook would result in visible stack corruption as per http://www.nntp.perl.org/group/perl.perl5.porters/2003/10/msg83192.html --- diff --git a/t/05-explicit-cleanee.t b/t/05-explicit-cleanee.t index e74b1a7..7cdd656 100644 --- a/t/05-explicit-cleanee.t +++ b/t/05-explicit-cleanee.t @@ -24,12 +24,7 @@ is(CleaneeTarget->summary->[ $_ ], $values[ $_ ], sprintf('testing sub in cleane # some torture -SKIP: { - - skip "This part of the test segfaults perl $] with both tie() and B::H::EOS." - . ' Actual code (e.g. DBIx::Class) works fine so did not investigate further', - 2000 if "$]" < 5.008003; - +{ local @INC = @INC; my @code; unshift @INC, sub { @@ -55,7 +50,7 @@ SKIP: { for (1..1000) { my $pkg = "CleaneeTarget::No${_}"; - my @val = require "CleaneeTarget/No${_}.pm"; + require "CleaneeTarget/No${_}.pm"; ok !$pkg->can('x_foo'), 'explicitely removed disappeared'; ok $pkg->can('x_bar'), 'not in explicit removal and still there';