From: Rafael Kitover <rkitover@cpan.org>
Date: Mon, 10 Aug 2009 06:44:51 +0000 (+0000)
Subject: document placeholders_with_type_conversion_supported and add a redispatch to reblesse... 
X-Git-Url: http://git.shadowcat.co.uk/gitweb/gitweb.cgi?a=commitdiff_plain;h=bc144884abdf828846ecc29122647fdaf1ac2487;p=dbsrgits%2FDBIx-Class-Historic.git

document placeholders_with_type_conversion_supported and add a redispatch to reblessed storage in DBI::update
---

diff --git a/lib/DBIx/Class/Storage/DBI.pm b/lib/DBIx/Class/Storage/DBI.pm
index 355edf9..9785585 100644
--- a/lib/DBIx/Class/Storage/DBI.pm
+++ b/lib/DBIx/Class/Storage/DBI.pm
@@ -1332,8 +1332,14 @@ sub insert_bulk {
 
 sub update {
   my $self = shift @_;
+
+# redispatch to update method of storage we reblessed into, if necessary
+  if (not $self->_driver_determined) {
+    $self->_determine_driver;
+    goto $self->can('update');
+  }
+
   my $source = shift @_;
-  $self->_determine_driver;
   my $bind_attributes = $self->source_bind_attributes($source);
 
   return $self->_execute('update' => [], $source, $bind_attributes, @_);
diff --git a/lib/DBIx/Class/Storage/DBI/Sybase/Base.pm b/lib/DBIx/Class/Storage/DBI/Sybase/Base.pm
index 2284289..4681d64 100644
--- a/lib/DBIx/Class/Storage/DBI/Sybase/Base.pm
+++ b/lib/DBIx/Class/Storage/DBI/Sybase/Base.pm
@@ -57,6 +57,11 @@ sub placeholders_supported {
 
 =head2 placeholders_with_type_conversion_supported 
 
+Checks if placeholders bound to non-string types throw implicit type conversion
+errors or not.
+
+See L<DBIx::Class::Storage::DBI::Sybase/connect_call_set_auto_cast>.
+
 =cut
 
 sub placeholders_with_type_conversion_supported {