From: Rafael Kitover Date: Tue, 20 Oct 2009 23:19:14 +0000 (+0000) Subject: removing Class::XSAccessor for now X-Git-Tag: v0.09004~14 X-Git-Url: http://git.shadowcat.co.uk/gitweb/gitweb.cgi?a=commitdiff_plain;h=b9a69571ab122a4e1a9ea8e4fa96adeda8de3bc8;p=p5sagit%2FClass-Accessor-Grouped.git removing Class::XSAccessor for now --- diff --git a/Changes b/Changes index 5d00ae7..8a9e866 100644 --- a/Changes +++ b/Changes @@ -1,5 +1,8 @@ Revision history for Class::Accessor::Grouped. +0.09002 Tue Oct 20 23:16:28 2009 + - removing Class::XSAccessor usage for now + 0.09001 Thu Oct 1 21:48:06 2009 - remove optional dep from Makefile.PL diff --git a/Makefile.PL b/Makefile.PL index d0ec6cf..933bd8e 100644 --- a/Makefile.PL +++ b/Makefile.PL @@ -13,7 +13,9 @@ requires 'Scalar::Util'; requires 'MRO::Compat'; requires 'Class::Inspector'; requires 'Sub::Name' => '0.04'; -requires 'Class::XSAccessor'; + +# removed due to segfaults, see _hasXS() +#requires 'Class::XSAccessor'; test_requires 'Sub::Identify'; diff --git a/lib/Class/Accessor/Grouped.pm b/lib/Class/Accessor/Grouped.pm index 33865b6..b836fb0 100644 --- a/lib/Class/Accessor/Grouped.pm +++ b/lib/Class/Accessor/Grouped.pm @@ -7,7 +7,7 @@ use Scalar::Util (); use MRO::Compat; use Sub::Name (); -our $VERSION = '0.09001'; +our $VERSION = '0.09002'; $VERSION = eval $VERSION; =head1 NAME @@ -440,20 +440,24 @@ sub get_super_paths { # This is now a hard, rather than optional dep. Since we dep on Sub::Name, we no # longer care about not using XS modules. + +# Class::XSAccessor is segfaulting in some places, so removing for now. { our $hasXS; - sub _hasXS { - return $hasXS if defined $hasXS; - - $hasXS = 0; - eval { - require Class::XSAccessor; - $hasXS = 1; - }; - - return $hasXS; - } + sub _hasXS { 0 } + +# sub _hasXS { +# return $hasXS if defined $hasXS; +# +# $hasXS = 0; +# eval { +# require Class::XSAccessor; +# $hasXS = 1; +# }; +# +# return $hasXS; +# } } 1;