From: Rafael Kitover Date: Wed, 10 Feb 2010 22:41:54 +0000 (+0000) Subject: Merge 'trunk' into 'handle_all_storage_methods_in_replicated' X-Git-Tag: v0.08119~23^2~2 X-Git-Url: http://git.shadowcat.co.uk/gitweb/gitweb.cgi?a=commitdiff_plain;h=b979420a9fa5c170a4b926882051f800c132750b;hp=e398f77e59be21bfdb90087caa30a092c87df0d6;p=dbsrgits%2FDBIx-Class.git Merge 'trunk' into 'handle_all_storage_methods_in_replicated' r21097@hlagh (orig r7843): ribasushi | 2009-11-04 04:55:51 -0500 r7817@Thesaurus (orig r7805): rbuels | 2009-10-21 02:37:28 +0200 making a branch, here we go again with the pg_unqualified_schema r7818@Thesaurus (orig r7806): rbuels | 2009-10-21 02:38:59 +0200 more pg unqualified schema tests, which expose a gap in the coverage r7819@Thesaurus (orig r7807): rbuels | 2009-10-21 03:10:38 +0200 gutted Pg storage driver's sequence discovery to just rely on DBD::Pg's last_insert_id. this needs testing with older versions of DBD::Pg r7821@Thesaurus (orig r7809): rbuels | 2009-10-21 04:00:39 +0200 more coverage in Pg sequence-discovery tests. i think this shows why last_insert_id cannot be used. r7822@Thesaurus (orig r7810): rbuels | 2009-10-21 04:07:05 +0200 reverted [7807], and just changed code to use the custom pg_catalog query, which is the only thing that works in the pathological case where DBIC is told a different primary key from the primary key that is set on the table in the DB ([7809] added testing for this) r7852@Thesaurus (orig r7840): rbuels | 2009-11-03 18:47:05 +0100 added Changes line mentioning tweak to Pg auto-inc fix r7854@Thesaurus (orig r7842): ribasushi | 2009-11-04 10:55:35 +0100 Cleanup exceptions r21100@hlagh (orig r7846): caelum | 2009-11-06 10:01:30 -0500 transactions for MSSQL over DBD::Sybase r21103@hlagh (orig r7849): caelum | 2009-11-10 07:16:18 -0500 made commit/rollback when disconnected an exception r21104@hlagh (orig r7850): robkinyon | 2009-11-10 11:19:57 -0500 Added a note about select r21105@hlagh (orig r7851): ribasushi | 2009-11-10 12:23:10 -0500 Changes r21109@hlagh (orig r7855): frew | 2009-11-11 15:56:37 -0500 RT50874 r21110@hlagh (orig r7856): frew | 2009-11-11 17:50:43 -0500 RT50828 r21111@hlagh (orig r7857): frew | 2009-11-11 17:54:15 -0500 clearer test message r21112@hlagh (orig r7858): frew | 2009-11-11 18:37:27 -0500 some cleanup for $rs->populate r21114@hlagh (orig r7860): ribasushi | 2009-11-11 19:35:36 -0500 Fix find on resultset with custom result_class r21115@hlagh (orig r7861): ribasushi | 2009-11-11 19:40:14 -0500 Fix return value of in_storage r21116@hlagh (orig r7862): ribasushi | 2009-11-11 19:43:48 -0500 Extra FAQ entry r21117@hlagh (orig r7863): ribasushi | 2009-11-11 20:11:25 -0500 Sanify _determine_driver handling in ::Storage::DBI r21118@hlagh (orig r7864): ribasushi | 2009-11-11 20:14:37 -0500 Add mysql determine_driver test by Pedro Melo r21123@hlagh (orig r7869): ribasushi | 2009-11-12 05:10:04 -0500 _cond_for_update_delete is hopelessly broken attempting to introspect SQLA1. Replace with a horrific but effective hack r21124@hlagh (orig r7870): ribasushi | 2009-11-12 05:15:12 -0500 Clarifying comment r21126@hlagh (orig r7872): ribasushi | 2009-11-12 18:13:40 -0500 The real fix for the non-introspectable condition bug, mst++ r21127@hlagh (orig r7873): ribasushi | 2009-11-12 18:24:56 -0500 Some cleanup r21129@hlagh (orig r7875): frew | 2009-11-13 04:01:37 -0500 fix subtle bug with Sybase database type determination r21134@hlagh (orig r7880): frew | 2009-11-13 18:53:29 -0500 release woo! r21136@hlagh (orig r7882): caelum | 2009-11-13 21:57:52 -0500 fix oracle dep in Makefile.PL r21137@hlagh (orig r7883): caelum | 2009-11-13 22:20:53 -0500 skip Oracle BLOB tests on DBD::Oracle == 1.23 r21139@hlagh (orig r7885): caelum | 2009-11-14 03:40:01 -0500 r7357@pentium (orig r7355): caelum | 2009-08-20 17:58:23 -0400 branch to support MSSQL over ADO r7358@pentium (orig r7356): caelum | 2009-08-21 00:32:14 -0400 something apparently working r7359@pentium (orig r7357): caelum | 2009-08-21 00:53:53 -0400 slightly better mars test, still passes r21141@hlagh (orig r7887): caelum | 2009-11-14 03:41:54 -0500 r7888@pentium (orig r7886): caelum | 2009-11-14 03:41:25 -0500 add TODO test for large column list in select r21143@hlagh (orig r7889): caelum | 2009-11-14 03:47:16 -0500 add ADO/MSSQL to Changes r21144@hlagh (orig r7890): caelum | 2009-11-14 04:27:29 -0500 fix the large column list test for ADO/MSSQL, now passes r21146@hlagh (orig r7892): caelum | 2009-11-14 06:20:58 -0500 fix Changes (ADO change in wrong release) r21147@hlagh (orig r7893): ribasushi | 2009-11-14 13:23:23 -0500 Release 0.08114 r21149@hlagh (orig r7895): ribasushi | 2009-11-15 06:09:17 -0500 Failing test to highlight mssql autoconnect regression r21150@hlagh (orig r7896): ribasushi | 2009-11-15 06:20:25 -0500 Fix plan r21155@hlagh (orig r7901): ribasushi | 2009-11-15 07:11:38 -0500 r7773@Thesaurus (orig r7761): norbi | 2009-10-05 14:49:06 +0200 Created branch 'prefetch_bug-unqualified_column_in_search_related_cond': A bug that manifests when a prefetched table's column is referenced without the table name in the condition of a search_related() on an M:N relationship. r7878@Thesaurus (orig r7866): ribasushi | 2009-11-12 02:36:08 +0100 Factor some code out r7879@Thesaurus (orig r7867): ribasushi | 2009-11-12 09:11:03 +0100 Factor out more stuff r7880@Thesaurus (orig r7868): ribasushi | 2009-11-12 09:21:04 +0100 Saner naming/comments r7910@Thesaurus (orig r7898): ribasushi | 2009-11-15 12:39:29 +0100 Move more code to DBIHacks, put back the update/delete rs check, just in case r7911@Thesaurus (orig r7899): ribasushi | 2009-11-15 13:01:34 +0100 TODOify test until we get an AST r7912@Thesaurus (orig r7900): ribasushi | 2009-11-15 13:10:15 +0100 Hide from pause r21163@hlagh (orig r7909): ribasushi | 2009-11-15 08:17:48 -0500 r7871@Thesaurus (orig r7859): ribasushi | 2009-11-12 00:46:07 +0100 Branches to test some ideas r7889@Thesaurus (orig r7877): abraxxa | 2009-11-13 12:05:50 +0100 added rels to view result classes in test schema r7890@Thesaurus (orig r7878): abraxxa | 2009-11-13 13:05:45 +0100 seems I found the bugger r7917@Thesaurus (orig r7905): ribasushi | 2009-11-15 13:29:23 +0100 FK constraints towards a view don't quite work r7918@Thesaurus (orig r7906): ribasushi | 2009-11-15 14:10:10 +0100 Turn into a straight-inheritance view class r7919@Thesaurus (orig r7907): ribasushi | 2009-11-15 14:11:03 +0100 Extensive test of virtual and classic view relationships r7920@Thesaurus (orig r7908): ribasushi | 2009-11-15 14:17:23 +0100 Fix non-sqlt schema file r21165@hlagh (orig r7911): caelum | 2009-11-15 12:31:37 -0500 fix MSSQL via DBD::Sybase regression r21172@hlagh (orig r7918): ribasushi | 2009-11-16 13:15:45 -0500 r7864@Thesaurus (orig r7852): edenc | 2009-11-10 20:15:15 +0100 branching for fixes related to prefetch, distinct and group by r7865@Thesaurus (orig r7853): edenc | 2009-11-10 20:21:38 +0100 added test case for ensuring a column mentioned in the order by clause is also included in the group by clause r7926@Thesaurus (orig r7914): ribasushi | 2009-11-16 08:09:30 +0100 Make _resolve_column_info function without supplying column names r7927@Thesaurus (orig r7915): ribasushi | 2009-11-16 08:11:17 +0100 Fix order_by/distinct bug r21179@hlagh (orig r7925): ribasushi | 2009-11-19 06:04:21 -0500 Bail out eary in Versioned if no versioning checks are requested r21180@hlagh (orig r7926): ribasushi | 2009-11-19 06:06:13 -0500 POD fixes r21182@hlagh (orig r7928): caelum | 2009-11-22 05:03:33 -0500 fix connection setup for Sybase r21185@hlagh (orig r7931): caelum | 2009-11-22 07:27:43 -0500 override _run_connection_actions for internal connection setup in sybase stuff, much cleaner this way r21189@hlagh (orig r7935): ribasushi | 2009-11-22 19:18:28 -0500 Whoops r21190@hlagh (orig r7936): ribasushi | 2009-11-22 19:28:50 -0500 Fix ::Versioned regression introduced in r7925 r21193@hlagh (orig r7939): caelum | 2009-11-23 06:32:10 -0500 add subname to rdbms_specific_methods wrapper r21195@hlagh (orig r7941): caelum | 2009-11-23 07:23:14 -0500 r21187@hlagh (orig r7933): ribasushi | 2009-11-22 18:38:34 -0500 New sybase refactor branch r21188@hlagh (orig r7934): ribasushi | 2009-11-22 19:06:48 -0500 refactor part1 r21192@hlagh (orig r7938): ribasushi | 2009-11-22 19:30:05 -0500 refactor part 2 r21194@hlagh (orig r7940): caelum | 2009-11-23 07:06:46 -0500 fix test r21584@hlagh (orig r7943): ribasushi | 2009-11-23 10:30:13 -0500 Add missing Sub::Name invocations and improve the SQLA Carp overrides r21586@hlagh (orig r7945): ribasushi | 2009-11-24 04:12:49 -0500 r7749@Thesaurus (orig r7738): norbi | 2009-09-28 22:01:39 +0200 Created branch 'void_populate_resultset_cond': Fixing a bug: $rs->populate in void context does not use the conditions from $rs. r7751@Thesaurus (orig r7740): norbi | 2009-09-28 23:26:06 +0200 r7935@vger: mendel | 2009-09-28 23:25:52 +0200 Undid the previous tweaks to the already existing tests and added new tests instead. r7928@Thesaurus (orig r7916): ribasushi | 2009-11-16 08:48:42 +0100 Change plan r7956@Thesaurus (orig r7944): ribasushi | 2009-11-24 10:10:49 +0100 Better naming and a bit leaner implementation. Main idea remains the same r21588@hlagh (orig r7947): ribasushi | 2009-11-24 04:39:52 -0500 Changes and prevent a spurious todo-pass r21591@hlagh (orig r7950): ribasushi | 2009-11-24 13:43:42 -0500 Extra sqla quoting test r21592@hlagh (orig r7951): ribasushi | 2009-11-24 13:48:01 -0500 Extra sqla quoting test(2) r21593@hlagh (orig r7952): ribasushi | 2009-11-25 15:24:10 -0500 wtf r21596@hlagh (orig r7955): ribasushi | 2009-11-26 05:07:06 -0500 cleanups r21597@hlagh (orig r7956): ribasushi | 2009-11-26 06:11:21 -0500 Sanify search_related chaining code (no functional changes) r21598@hlagh (orig r7957): ribasushi | 2009-11-26 06:52:05 -0500 Another count() quirk down r21599@hlagh (orig r7958): ribasushi | 2009-11-26 08:23:28 -0500 Add a no-accessor column to generally test handling r21601@hlagh (orig r7960): ribasushi | 2009-11-26 09:32:17 -0500 Whoops, wrong accessor (things still work though) r21606@hlagh (orig r7965): ribasushi | 2009-11-26 10:43:21 -0500 r7971@Thesaurus (orig r7959): ribasushi | 2009-11-26 14:54:17 +0100 New branch for get_inflated_column bugfix r7974@Thesaurus (orig r7962): ribasushi | 2009-11-26 15:56:20 +0100 Fix for rt46953 r7975@Thesaurus (orig r7963): ribasushi | 2009-11-26 16:05:17 +0100 Make Test::More happy r7976@Thesaurus (orig r7964): ribasushi | 2009-11-26 16:43:09 +0100 Changes r21609@hlagh (orig r7968): ribasushi | 2009-11-26 19:38:11 -0500 Fix search_related wrt grouped resultsets (distinct is currently passed to the new resultset, this is probably wrong) r21616@hlagh (orig r7975): ribasushi | 2009-11-28 10:54:23 -0500 Cleanup the s.c.o. index r21617@hlagh (orig r7976): ribasushi | 2009-11-28 10:57:04 -0500 Test based on http://lists.scsys.co.uk/pipermail/dbix-class/2009-November/008599.html r21714@hlagh (orig r7995): castaway | 2009-11-30 10:20:19 -0500 Remove over-emphasis on +select/+as. Add docs on prefetch and other ways to get related data, with caveats etc. r21716@hlagh (orig r7997): dew | 2009-11-30 13:37:00 -0500 Alter the docs for has_many relationships to make them a little easier to grok r21793@hlagh (orig r8009): castaway | 2009-12-02 08:19:40 -0500 Added note about prefetch and has_many related objects r21891@hlagh (orig r8017): ribasushi | 2009-12-03 07:24:04 -0500 Source sanity check on subqueried update/delete r21892@hlagh (orig r8018): ribasushi | 2009-12-03 08:39:37 -0500 Sanify populate arg handling r21902@hlagh (orig r8028): ribasushi | 2009-12-03 20:46:20 -0500 r7935@Thesaurus (orig r7923): ribasushi | 2009-11-19 11:05:04 +0100 Branches for RTs r7965@Thesaurus (orig r7953): ribasushi | 2009-11-26 00:19:21 +0100 Test and fix scalarref in an inflatable slot corner-case r7966@Thesaurus (orig r7954): ribasushi | 2009-11-26 00:24:23 +0100 Looks like we nailed a todo r8038@Thesaurus (orig r8026): ribasushi | 2009-12-04 02:45:40 +0100 Changes r8039@Thesaurus (orig r8027): ribasushi | 2009-12-04 02:46:08 +0100 Changes(2) r21917@hlagh (orig r8043): ribasushi | 2009-12-07 09:11:25 -0500 Forgotten auto-savepoint example patch r21953@hlagh (orig r8045): ribasushi | 2009-12-08 08:13:38 -0500 Weird test case r21954@hlagh (orig r8046): ribasushi | 2009-12-08 08:23:31 -0500 Fix the test - code is correct r21959@hlagh (orig r8051): ribasushi | 2009-12-08 20:33:30 -0500 It's almost 2010 - load_components ('Core') is like ewwww r21968@hlagh (orig r8055): caelum | 2009-12-09 12:13:33 -0500 workaround for evil ADO bug r21969@hlagh (orig r8056): ribasushi | 2009-12-09 17:13:59 -0500 r8022@Thesaurus (orig r8010): frew | 2009-12-02 17:57:17 +0100 branch for replacing TOP with RNO in MSSQL r8027@Thesaurus (orig r8015): frew | 2009-12-03 02:48:36 +0100 Switch to RowNumberOver for MSSQL r8028@Thesaurus (orig r8016): ribasushi | 2009-12-03 10:03:18 +0100 The correct top100 mssql solution and test r8031@Thesaurus (orig r8019): frew | 2009-12-03 15:56:35 +0100 fix RNO for MSSQL to not use a kludgy regexp r8032@Thesaurus (orig r8020): frew | 2009-12-04 01:33:28 +0100 initial (broken) version of 42rno.t r8033@Thesaurus (orig r8021): frew | 2009-12-04 01:37:06 +0100 first shot at moving stuff around r8034@Thesaurus (orig r8022): frew | 2009-12-04 01:45:42 +0100 rename files to get rid of numbers and use folders r8035@Thesaurus (orig r8023): frew | 2009-12-04 01:48:00 +0100 missed toplimit r8036@Thesaurus (orig r8024): frew | 2009-12-04 01:52:44 +0100 still broken rno test, but now it actually tests mssql r8042@Thesaurus (orig r8030): ribasushi | 2009-12-04 09:34:56 +0100 Variable clash r8043@Thesaurus (orig r8031): ribasushi | 2009-12-04 11:44:47 +0100 The complex prefetch rewrite actually takes care of this as cleanly as possible r8044@Thesaurus (orig r8032): ribasushi | 2009-12-04 11:47:22 +0100 Smarter implementation of the select top 100pct subselect handling r8045@Thesaurus (orig r8033): ribasushi | 2009-12-04 12:07:05 +0100 Add support for unordered limited resultsets Rename the limit helper to signify it is MS specific Make sure we don't lose group_by/having clauses r8046@Thesaurus (orig r8034): ribasushi | 2009-12-04 12:07:56 +0100 Un-todoify mssql limit tests - no changes necessary (throw away the obsolete generated sql checks) r8047@Thesaurus (orig r8035): ribasushi | 2009-12-04 12:24:13 +0100 Tests for bindvar propagation and Changes r8049@Thesaurus (orig r8037): ribasushi | 2009-12-04 15:01:32 +0100 KISS - a select(1) makes perfect ordering criteria r8050@Thesaurus (orig r8038): ribasushi | 2009-12-04 15:06:11 +0100 Unify the MSSQL and DB2 RNO implementations - they are the same r8051@Thesaurus (orig r8039): ribasushi | 2009-12-05 10:29:50 +0100 Wrap mssql selects in yet another subquery to make limited right-ordered join resultsets possible r8052@Thesaurus (orig r8040): ribasushi | 2009-12-05 10:46:41 +0100 Better not touch Top - it's too complex at this point r8053@Thesaurus (orig r8041): ribasushi | 2009-12-05 11:03:00 +0100 Extend test just a bit more r8054@Thesaurus (orig r8042): ribasushi | 2009-12-05 11:44:25 +0100 DB2 and MSSQL have different default order syntaxes r8056@Thesaurus (orig r8044): frew | 2009-12-08 02:10:06 +0100 add version check for mssql 2005 and greater r8059@Thesaurus (orig r8047): frew | 2009-12-08 16:15:50 +0100 real exception instead of die r8061@Thesaurus (orig r8049): ribasushi | 2009-12-09 00:19:49 +0100 Test for immediate connection with known storage type r8062@Thesaurus (orig r8050): frew | 2009-12-09 01:24:45 +0100 fix mssql version check so it's lazier r8064@Thesaurus (orig r8052): ribasushi | 2009-12-09 02:40:51 +0100 Fix comment r8066@Thesaurus (orig r8054): caelum | 2009-12-09 16:12:56 +0100 fix _get_mssql_version for ODBC r21972@hlagh (orig r8059): frew | 2009-12-09 18:32:55 -0500 fail nicely if user doesn't have perms for xp_msver r21974@hlagh (orig r8061): ribasushi | 2009-12-10 03:36:21 -0500 Changes r21975@hlagh (orig r8062): ribasushi | 2009-12-10 03:53:38 -0500 First half of distinct cleanup r21976@hlagh (orig r8063): frew | 2009-12-10 10:04:37 -0500 release 0.08115 r22042@hlagh (orig r8064): ribasushi | 2009-12-12 06:31:12 -0500 Even clearer unloaded FK exception r22044@hlagh (orig r8066): ribasushi | 2009-12-12 08:27:18 -0500 As clear as it gets r22135@hlagh (orig r8129): ovid | 2009-12-16 11:40:50 -0500 Have has_one/might_have warn if set on nullable columns. r22194@hlagh (orig r8131): caelum | 2009-12-17 07:30:10 -0500 somewhat better fix for ADO r22195@hlagh (orig r8132): caelum | 2009-12-17 07:34:20 -0500 minor changes r22238@hlagh (orig r8134): caelum | 2009-12-17 11:44:34 -0500 cleanup source_bind_attributes for ADO r22239@hlagh (orig r8135): caelum | 2009-12-17 12:09:55 -0500 more types for ADO fix, and documentation r22240@hlagh (orig r8136): abraxxa | 2009-12-17 13:54:55 -0500 Cookbook POD fix for add_drop_table instead of add_drop_tables r22250@hlagh (orig r8146): ribasushi | 2009-12-18 08:55:53 -0500 r8150@Thesaurus (orig r8138): abraxxa | 2009-12-17 23:22:07 +0100 Views without a view_definition won't be added to the SQL::Translator::Schema by the parser + tests r8151@Thesaurus (orig r8139): abraxxa | 2009-12-17 23:23:33 +0100 test cleanups r8153@Thesaurus (orig r8141): abraxxa | 2009-12-18 14:34:14 +0100 throw_exception if view_definition is missing instead of silent skipping + test changes r8154@Thesaurus (orig r8142): abraxxa | 2009-12-18 14:40:32 +0100 use Test::Exception r8155@Thesaurus (orig r8143): abraxxa | 2009-12-18 14:42:00 +0100 fixed Changes r8156@Thesaurus (orig r8144): abraxxa | 2009-12-18 14:44:52 +0100 test cleanups r8157@Thesaurus (orig r8145): ribasushi | 2009-12-18 14:46:26 +0100 Another bitr r22252@hlagh (orig r8148): ribasushi | 2009-12-18 09:04:34 -0500 Fix no_index entries r22254@hlagh (orig r8150): abraxxa | 2009-12-18 09:59:58 -0500 Schema POD inprovement for dclone r22255@hlagh (orig r8151): abraxxa | 2009-12-18 10:07:27 -0500 link to DBIx::Class::Row r22256@hlagh (orig r8152): abraxxa | 2009-12-18 10:08:56 -0500 fixed typo in Changes r22257@hlagh (orig r8153): abraxxa | 2009-12-18 10:14:47 -0500 dclone pod take #2 r22261@hlagh (orig r8157): ribasushi | 2009-12-19 12:47:42 -0500 detabify r22262@hlagh (orig r8158): ribasushi | 2009-12-19 13:41:42 -0500 Fix RT52812 r22263@hlagh (orig r8159): caelum | 2009-12-23 01:16:29 -0500 minor POD fixes r22274@hlagh (orig r8163): ribasushi | 2009-12-24 03:59:52 -0500 Fix deployment_statements context sensitivity regression r22275@hlagh (orig r8164): ribasushi | 2009-12-24 04:13:37 -0500 Don't call the PK setter if no PK r22319@hlagh (orig r8192): caelum | 2009-12-30 16:58:47 -0500 bump CAG dep r22346@hlagh (orig r8219): matthewt | 2010-01-01 19:41:12 -0500 fix typo in variable name r22377@hlagh (orig r8226): rafl | 2010-01-02 12:46:40 -0500 Merge branch 'native_traits' * native_traits: Port replicated storage from MXAH to native traits. Create branch native_traits r22405@hlagh (orig r8232): caelum | 2010-01-03 18:30:51 -0500 fix _rebless into sybase/mssql/nobindvars r22420@hlagh (orig r8235): caelum | 2010-01-05 07:54:56 -0500 r22328@hlagh (orig r8201): caelum | 2009-12-31 12:29:51 -0500 new branch to fix table aliases in queries over the 30char limit r22329@hlagh (orig r8202): caelum | 2009-12-31 12:55:50 -0500 failing test r22330@hlagh (orig r8203): caelum | 2009-12-31 13:00:35 -0500 switch oracle tests to done_testing() r22331@hlagh (orig r8204): caelum | 2009-12-31 15:02:50 -0500 got something working r22332@hlagh (orig r8205): caelum | 2009-12-31 15:08:30 -0500 POD touchups r22343@hlagh (orig r8216): caelum | 2010-01-01 07:42:03 -0500 fix uninitialized warning and a bug in ResultSet r22419@hlagh (orig r8234): caelum | 2010-01-05 07:53:18 -0500 append half of a base64 MD5 to shortened table aliases for Oracle r22422@hlagh (orig r8237): caelum | 2010-01-05 09:27:40 -0500 minor change: use more of the hash if possible for oracle table alias shortening r22424@hlagh (orig r8239): caelum | 2010-01-05 20:20:17 -0500 bump perl_version to 5.8.1 r22425@hlagh (orig r8240): caelum | 2010-01-05 20:21:41 -0500 remove alignment mark on base64 md5 r22459@hlagh (orig r8248): ribasushi | 2010-01-07 05:21:55 -0500 5.8.1 is minimum required perl r22460@hlagh (orig r8249): ribasushi | 2010-01-07 05:22:42 -0500 Minor optimization r22461@hlagh (orig r8250): ribasushi | 2010-01-07 05:23:35 -0500 Wrong title r22464@hlagh (orig r8253): ribasushi | 2010-01-08 11:48:50 -0500 Resolve problem reported by http://lists.scsys.co.uk/pipermail/dbix-class/2009-December/008699.html r22465@hlagh (orig r8254): ribasushi | 2010-01-08 11:52:01 -0500 Put utf8columns in line with the store_column fix r22466@hlagh (orig r8255): ribasushi | 2010-01-08 13:03:26 -0500 Tests while hunting for something else r22467@hlagh (orig r8256): ribasushi | 2010-01-08 13:14:42 -0500 Make test look even more like http://lists.scsys.co.uk/pipermail/dbix-class/2009-November/008599.html r22476@hlagh (orig r8265): ribasushi | 2010-01-08 20:16:14 -0500 r8263@Thesaurus (orig r8251): ribasushi | 2010-01-08 15:43:38 +0100 New branch to find a leak r8264@Thesaurus (orig r8252): ribasushi | 2010-01-08 15:52:46 +0100 Weird test failures r8272@Thesaurus (orig r8260): ribasushi | 2010-01-09 01:24:56 +0100 Proper invocation r8273@Thesaurus (orig r8261): ribasushi | 2010-01-09 01:35:34 +0100 Test for the real leak reason r8274@Thesaurus (orig r8262): ribasushi | 2010-01-09 01:37:33 +0100 Void ctx as it should be r8275@Thesaurus (orig r8263): ribasushi | 2010-01-09 02:10:13 +0100 A "fix" for sqlt-related schema leaks r8276@Thesaurus (orig r8264): ribasushi | 2010-01-09 02:15:53 +0100 Changes r22496@hlagh (orig r8275): caelum | 2010-01-10 05:29:06 -0500 r22483@hlagh (orig r8272): caelum | 2010-01-09 05:52:15 -0500 new branch to add "normalize_connect_info" class method to Storage::DBI r22495@hlagh (orig r8274): caelum | 2010-01-10 05:27:42 -0500 split connect_info parser out into private _normalize_connect_info r22498@hlagh (orig r8277): caelum | 2010-01-10 06:04:52 -0500 fix connection details in ::DBI::Replicated docs r22545@hlagh (orig r8279): ribasushi | 2010-01-11 03:50:21 -0500 r8077@Thesaurus (orig r8065): ribasushi | 2009-12-12 14:24:30 +0100 Branch for yet another mssql ordered prefetch problem r8079@Thesaurus (orig r8067): ribasushi | 2009-12-12 14:37:48 +0100 prefetch does not get disassembled properly r8112@Thesaurus (orig r8100): ribasushi | 2009-12-13 00:07:00 +0100 Extra test to highlight search_related inefficiency r8113@Thesaurus (orig r8101): ribasushi | 2009-12-13 00:17:44 +0100 Real test for search_related and prefetch r8114@Thesaurus (orig r8102): ribasushi | 2009-12-13 00:19:57 +0100 Fix corner case regression on search_related on a prefetching rs r8115@Thesaurus (orig r8103): ribasushi | 2009-12-13 00:21:05 +0100 Isolate prefetch heads using RNO with a subquery r8116@Thesaurus (orig r8104): ribasushi | 2009-12-13 00:23:46 +0100 Changes r8125@Thesaurus (orig r8113): ribasushi | 2009-12-15 13:06:26 +0100 Extend mssql limited prefetch tests r8126@Thesaurus (orig r8114): ribasushi | 2009-12-15 13:08:56 +0100 Add extra test to prove Alan wrong :) r8132@Thesaurus (orig r8120): ribasushi | 2009-12-16 00:38:04 +0100 Do not realias tables in the RNO subqueries r8133@Thesaurus (orig r8121): ribasushi | 2009-12-16 00:50:52 +0100 Deliberately disturb alphabetical order r8134@Thesaurus (orig r8122): ribasushi | 2009-12-16 10:26:43 +0100 Got a failing test r8135@Thesaurus (orig r8123): ribasushi | 2009-12-16 10:49:10 +0100 Cleanup r8136@Thesaurus (orig r8124): ribasushi | 2009-12-16 10:51:58 +0100 More moving around r8137@Thesaurus (orig r8125): ribasushi | 2009-12-16 11:25:37 +0100 The real mssql problem - it's... bad r8138@Thesaurus (orig r8126): ribasushi | 2009-12-16 11:29:20 +0100 Clearer debug r8139@Thesaurus (orig r8127): ribasushi | 2009-12-16 11:47:48 +0100 This is horrific but the tests pass... maybe someone will figure out something better r8140@Thesaurus (orig r8128): ribasushi | 2009-12-16 16:45:47 +0100 cleanup tests r8187@Thesaurus (orig r8175): ribasushi | 2009-12-24 16:22:30 +0100 Ordered subqueries do not work in mssql after all r8271@Thesaurus (orig r8259): ribasushi | 2010-01-08 23:58:13 +0100 Cleaner RNO sql r8279@Thesaurus (orig r8267): ribasushi | 2010-01-09 10:13:16 +0100 Subqueries no longer experimental r8280@Thesaurus (orig r8268): ribasushi | 2010-01-09 11:26:46 +0100 Close the book on mssql ordered subqueries r8281@Thesaurus (orig r8269): ribasushi | 2010-01-09 11:36:36 +0100 Changes and typos r8283@Thesaurus (orig r8271): ribasushi | 2010-01-09 11:42:21 +0100 Highlight the real problem r8285@Thesaurus (orig r8273): ribasushi | 2010-01-10 10:07:10 +0100 Rename subquery to subselect and rewrite POD (per castaway) r8290@Thesaurus (orig r8278): ribasushi | 2010-01-10 17:01:24 +0100 rename as per mst r22549@hlagh (orig r8283): caelum | 2010-01-11 17:42:30 -0500 make a public ::Schema::unregister_source r22552@hlagh (orig r8286): abraxxa | 2010-01-12 12:04:18 -0500 fixed a typo in Changes more detailed explanation for the warning about has_one/might_have rels on nullable columns r22561@hlagh (orig r8295): abraxxa | 2010-01-13 11:28:05 -0500 added the sources parser arg to the example code r22642@hlagh (orig r8315): ribasushi | 2010-01-14 19:25:39 -0500 r8167@Thesaurus (orig r8155): ribasushi | 2009-12-19 12:50:13 +0100 New branch for null-only-result fix r8168@Thesaurus (orig r8156): ribasushi | 2009-12-19 12:51:21 +0100 Failing test r8322@Thesaurus (orig r8310): ribasushi | 2010-01-15 00:48:09 +0100 Correct test order r8323@Thesaurus (orig r8311): ribasushi | 2010-01-15 01:15:33 +0100 Generalize the to-node inner-join-er to apply to all related_resultset calls, not just counts r8324@Thesaurus (orig r8312): ribasushi | 2010-01-15 01:16:05 +0100 Adjust sql-emitter tests r8326@Thesaurus (orig r8314): ribasushi | 2010-01-15 01:25:10 +0100 One more sql-test fix and changes r22643@hlagh (orig r8316): ribasushi | 2010-01-14 19:31:58 -0500 Strict mysql bugfix r22644@hlagh (orig r8317): ribasushi | 2010-01-14 19:38:53 -0500 Better description of mysql strict option r22646@hlagh (orig r8319): ribasushi | 2010-01-14 21:12:13 -0500 Update troubleshooting doc r22652@hlagh (orig r8325): ribasushi | 2010-01-15 11:13:28 -0500 RT52674 r22661@hlagh (orig r8334): ribasushi | 2010-01-17 03:41:49 -0500 No method aliasing in OO code, *ever* r22687@hlagh (orig r8360): ribasushi | 2010-01-18 05:54:51 -0500 Adjust my email r22701@hlagh (orig r8374): ribasushi | 2010-01-19 07:07:07 -0500 r8340@Thesaurus (orig r8328): abraxxa | 2010-01-15 19:21:20 +0100 added branch no_duplicate_indexes_for_pk_cols with test and fix r8343@Thesaurus (orig r8331): abraxxa | 2010-01-15 19:32:16 +0100 don't use eq_set in test r8344@Thesaurus (orig r8332): abraxxa | 2010-01-15 19:44:04 +0100 don't sort the primary columns because order matters for indexes r8345@Thesaurus (orig r8333): abraxxa | 2010-01-15 19:56:46 +0100 don't sort the key columns because the order of columns is important for indexes r8372@Thesaurus (orig r8359): abraxxa | 2010-01-18 10:22:09 +0100 don't sort the columns in the tests either r8378@Thesaurus (orig r8365): abraxxa | 2010-01-18 15:39:28 +0100 added pod section for parser args r8379@Thesaurus (orig r8366): abraxxa | 2010-01-18 15:53:08 +0100 better pod thanks to ribasushi r8380@Thesaurus (orig r8367): abraxxa | 2010-01-18 16:04:34 +0100 test and pod fixes r8383@Thesaurus (orig r8370): abraxxa | 2010-01-19 12:38:44 +0100 fixed Authors section added License section fixed t/86sqlt.t tests r8384@Thesaurus (orig r8371): ribasushi | 2010-01-19 12:59:52 +0100 Regenaretd under new parser r8385@Thesaurus (orig r8372): ribasushi | 2010-01-19 13:03:51 +0100 Minor style change and white space trim r8386@Thesaurus (orig r8373): ribasushi | 2010-01-19 13:06:54 +0100 Changes abraxxa++ r22704@hlagh (orig r8377): ribasushi | 2010-01-19 07:41:03 -0500 Some minor test refactor and tab cleanups r22708@hlagh (orig r8381): frew | 2010-01-19 11:34:10 -0500 add test to ensure no tabs in perl files r22711@hlagh (orig r8384): frew | 2010-01-19 12:00:12 -0500 fix test to be an author dep r22712@hlagh (orig r8385): ribasushi | 2010-01-19 12:19:40 -0500 First round of detabification r22713@hlagh (orig r8386): frew | 2010-01-19 17:42:50 -0500 Add EOL test r22715@hlagh (orig r8388): ribasushi | 2010-01-20 02:32:39 -0500 Fix minor RSC bug r22716@hlagh (orig r8389): roman | 2010-01-20 09:47:26 -0500 Added a FAQ entry titled: How do I override a run time method (e.g. a relationship accessor)? r22717@hlagh (orig r8390): roman | 2010-01-20 10:31:41 -0500 Added myself as a contributor. r22722@hlagh (orig r8395): jhannah | 2010-01-21 00:48:14 -0500 Added FAQ: Custom methods in Result classes r22727@hlagh (orig r8400): frew | 2010-01-21 22:17:20 -0500 add _is_numeric to ::Row r22732@hlagh (orig r8405): ribasushi | 2010-01-22 05:00:05 -0500 Generalize autoinc/count test r22734@hlagh (orig r8407): ribasushi | 2010-01-22 05:11:49 -0500 Final round of detabify r22735@hlagh (orig r8408): ribasushi | 2010-01-22 05:12:54 -0500 Temporarily disable whitespace checkers r22740@hlagh (orig r8413): ribasushi | 2010-01-22 05:35:15 -0500 Moev failing regression test away from trunk r22745@hlagh (orig r8418): frew | 2010-01-22 11:05:12 -0500 fix name of _is_numeric to _is_column_numeric r22751@hlagh (orig r8424): ribasushi | 2010-01-26 03:33:42 -0500 Switch to Test::Exception r22752@hlagh (orig r8425): ribasushi | 2010-01-26 03:48:30 -0500 Test txn_scope_guard regression r22753@hlagh (orig r8426): ribasushi | 2010-01-26 04:10:11 -0500 Fix txn_begin on external non-AC coderef regression r22757@hlagh (orig r8430): ribasushi | 2010-01-26 08:19:50 -0500 r8304@Thesaurus (orig r8292): nigel | 2010-01-13 16:05:48 +0100 Branch to extend ::Schema::Versioned to handle series of upgrades r8320@Thesaurus (orig r8308): nigel | 2010-01-14 16:52:50 +0100 Changes to support multiple step schema version updates r8321@Thesaurus (orig r8309): nigel | 2010-01-14 17:05:21 +0100 Changelog for Changes to support multiple step schema version updates r8393@Thesaurus (orig r8380): ribasushi | 2010-01-19 13:59:51 +0100 Botched merge (tests still fail) r8395@Thesaurus (orig r8382): ribasushi | 2010-01-19 17:37:07 +0100 More cleanup r8396@Thesaurus (orig r8383): ribasushi | 2010-01-19 17:48:09 +0100 Fix last pieces of retardation and UNtodo the quick cycle r8442@Thesaurus (orig r8429): ribasushi | 2010-01-26 14:18:53 +0100 No need for 2 statements to get the version r22759@hlagh (orig r8432): ribasushi | 2010-01-26 08:22:16 -0500 r8161@Thesaurus (orig r8149): ovid | 2009-12-18 15:59:56 +0100 Prefetch queries make inefficient SQL when combined with a pager. This branch is to try to isolate some of the join conditions and figure out if we can fix this. r8166@Thesaurus (orig r8154): ovid | 2009-12-18 18:17:55 +0100 Refactor internals to expose some join logic. Awful method and args :( r8319@Thesaurus (orig r8307): ovid | 2010-01-14 15:37:35 +0100 Attempt to factor our alias handling has mostly failed. r8330@Thesaurus (orig r8318): ribasushi | 2010-01-15 03:02:21 +0100 Better refactor r8332@Thesaurus (orig r8320): ribasushi | 2010-01-15 03:14:39 +0100 Better varnames r8347@Thesaurus (orig r8335): ribasushi | 2010-01-17 11:33:55 +0100 More mangling r8348@Thesaurus (orig r8336): ribasushi | 2010-01-17 13:44:00 +0100 Getting warmer r8349@Thesaurus (orig r8337): ribasushi | 2010-01-17 14:00:20 +0100 That was tricky :) r8352@Thesaurus (orig r8340): ribasushi | 2010-01-17 15:57:06 +0100 Turned out to be much trickier r8354@Thesaurus (orig r8342): ribasushi | 2010-01-17 16:29:20 +0100 This is made out of awesome r8355@Thesaurus (orig r8343): ribasushi | 2010-01-17 16:46:02 +0100 Changes r8400@Thesaurus (orig r8387): ribasushi | 2010-01-20 08:17:44 +0100 Whoops - need to dsable quoting r22773@hlagh (orig r8446): ribasushi | 2010-01-27 05:56:15 -0500 Clean up some stuff r22777@hlagh (orig r8450): ribasushi | 2010-01-27 06:08:04 -0500 Merge some cleanups from the prefetch branch r22780@hlagh (orig r8453): ribasushi | 2010-01-27 06:33:33 -0500 DSNs can not be empty r22880@hlagh (orig r8458): frew | 2010-01-27 15:38:42 -0500 fix silly multipk bug r22881@hlagh (orig r8459): ribasushi | 2010-01-28 05:13:16 -0500 Consolidate insert_bulk guards (and make them show up correctly in the trace) r22882@hlagh (orig r8460): ribasushi | 2010-01-28 05:28:30 -0500 Fix bogus test DDL r22889@hlagh (orig r8467): ribasushi | 2010-01-28 16:11:59 -0500 r8381@Thesaurus (orig r8368): moses | 2010-01-18 16:41:38 +0100 Test commit r8425@Thesaurus (orig r8412): ribasushi | 2010-01-22 11:25:01 +0100 Informix test + cleanups r8428@Thesaurus (orig r8415): ribasushi | 2010-01-22 11:59:25 +0100 Initial informix support r22891@hlagh (orig r8469): ribasushi | 2010-01-28 16:19:23 -0500 Informix changes r22892@hlagh (orig r8470): ribasushi | 2010-01-29 06:01:41 -0500 Require non-warning-spewing MooseX::Types r22893@hlagh (orig r8471): ribasushi | 2010-01-29 06:15:15 -0500 Enhance warning test a bit (seems to fail on 5.8) r22894@hlagh (orig r8472): ribasushi | 2010-01-29 07:00:54 -0500 Fugly 5.8 workaround r22903@hlagh (orig r8481): frew | 2010-01-31 00:47:42 -0500 cleanup (3 arg open, 1 grep instead of 3) r22905@hlagh (orig r8483): ribasushi | 2010-01-31 04:04:43 -0500 better skip message r22919@hlagh (orig r8497): caelum | 2010-02-01 06:07:13 -0500 throw exception on attempt to insert a blob with DBD::Oracle == 1.23 r22920@hlagh (orig r8498): caelum | 2010-02-01 06:12:48 -0500 add RT link for Oracle blob bug in DBD::Oracle == 1.23 r22980@hlagh (orig r8514): caelum | 2010-02-02 17:20:17 -0500 r22968@hlagh (orig r8502): caelum | 2010-02-02 05:30:47 -0500 branch to support Sybase SQL Anywhere r22971@hlagh (orig r8505): caelum | 2010-02-02 07:21:13 -0500 ASA last_insert_id and limit support, still needs BLOB support r22972@hlagh (orig r8506): caelum | 2010-02-02 08:33:57 -0500 deref table name if needed, check all columns for identity column not just PK r22973@hlagh (orig r8507): caelum | 2010-02-02 08:48:11 -0500 test blobs, they work, didn't have to do anything r22974@hlagh (orig r8508): caelum | 2010-02-02 09:15:44 -0500 fix stupid identity bug, test empty insert (works), test DTs (not working yet) r22976@hlagh (orig r8510): caelum | 2010-02-02 14:31:00 -0500 rename ::Sybase::ASA to ::SQLAnywhere, per mst r22978@hlagh (orig r8512): caelum | 2010-02-02 17:02:29 -0500 DT inflation now works r22979@hlagh (orig r8513): caelum | 2010-02-02 17:18:06 -0500 minor POD update r22981@hlagh (orig r8515): caelum | 2010-02-02 17:23:26 -0500 r22895@hlagh (orig r8473): caelum | 2010-01-30 03:57:26 -0500 branch to fix computed columns in Sybase ASE r22911@hlagh (orig r8489): caelum | 2010-01-31 07:18:33 -0500 empty insert into a Sybase table with computed columns and either data_type => undef or default_value => SCALARREF works now r22912@hlagh (orig r8490): caelum | 2010-01-31 07:39:32 -0500 add POD about computed columns and timestamps for Sybase r22918@hlagh (orig r8496): caelum | 2010-02-01 05:09:07 -0500 update POD about Schema::Loader for Sybase r22984@hlagh (orig r8518): ribasushi | 2010-02-02 17:57:27 -0500 r8512@Thesaurus (orig r8499): boghead | 2010-02-01 23:38:13 +0100 - Creating a branch for adding _post_inflate_datetime and _pre_deflate_datetime to InflateColumn::DateTime r8513@Thesaurus (orig r8500): boghead | 2010-02-01 23:42:14 +0100 - Add _post_inflate_datetime and _pre_deflate_datetime to InflateColumn::DateTime to allow for modifying DateTime objects after inflation or before deflation. r8524@Thesaurus (orig r8511): boghead | 2010-02-02 22:59:28 +0100 - Simplify by allowing moving column_info depreciated {extra}{timezone} data to {timezone} (and the same with locale) r22986@hlagh (orig r8520): caelum | 2010-02-02 23:19:59 -0500 support for Sybase SQL Anywhere through ODBC r22989@hlagh (orig r8523): ribasushi | 2010-02-03 02:27:54 -0500 Changes r22990@hlagh (orig r8524): ribasushi | 2010-02-03 02:31:20 -0500 Quote fail r22991@hlagh (orig r8525): caelum | 2010-02-03 07:21:37 -0500 test DT inflation for Sybase SQL Anywhere over ODBC too r22992@hlagh (orig r8526): caelum | 2010-02-03 11:36:39 -0500 minor code cleanup for SQL Anywhere last_insert_id r23001@hlagh (orig r8527): ribasushi | 2010-02-04 05:28:33 -0500 Fix bug reported by tommyt r23009@hlagh (orig r8535): ribasushi | 2010-02-04 08:34:45 -0500 Prepare for new SQLA release r23021@hlagh (orig r8547): ribasushi | 2010-02-05 02:59:04 -0500 Refactor some evil code r23029@hlagh (orig r8552): ribasushi | 2010-02-05 11:00:12 -0500 Looks like RSC is finally (halfway) fixed r23030@hlagh (orig r8553): ribasushi | 2010-02-05 11:07:13 -0500 RSC subquery can not include the prefetch r23031@hlagh (orig r8554): ribasushi | 2010-02-05 11:10:29 -0500 Fix typo and borked test r23033@hlagh (orig r8556): ribasushi | 2010-02-05 11:33:12 -0500 Release 0.08116 r23035@hlagh (orig r8558): ribasushi | 2010-02-05 12:01:33 -0500 No idea how I missed all these fails... r23036@hlagh (orig r8559): ribasushi | 2010-02-05 12:13:34 -0500 Release 0.08117 r23038@hlagh (orig r8561): ribasushi | 2010-02-05 12:51:12 -0500 Try to distinguish trunk from official versions r23044@hlagh (orig r8567): gshank | 2010-02-05 16:29:24 -0500 add doc on 'where' attribute r23071@hlagh (orig r8574): frew | 2010-02-07 15:07:03 -0500 add as_subselect_rs r23072@hlagh (orig r8575): frew | 2010-02-07 15:13:04 -0500 fix longstanding unmentioned bug ("me") r23073@hlagh (orig r8576): frew | 2010-02-08 00:17:43 -0500 another example of as_subselect_rs r23074@hlagh (orig r8577): frew | 2010-02-08 00:23:58 -0500 fix bug in UTF8Columns r23075@hlagh (orig r8578): ribasushi | 2010-02-08 03:31:01 -0500 Extend utf8columns test to trap fixed bug r23076@hlagh (orig r8579): ribasushi | 2010-02-08 06:03:23 -0500 Cleanup rel accessor type handling r23077@hlagh (orig r8580): ribasushi | 2010-02-08 06:20:47 -0500 Fix some fallout r23079@hlagh (orig r8582): ribasushi | 2010-02-08 06:38:19 -0500 Merge some obsolete code cleanup from the prefetch branch r23080@hlagh (orig r8583): ribasushi | 2010-02-08 06:42:09 -0500 Merge fix of RT54039 from prefetch branch r23082@hlagh (orig r8585): ribasushi | 2010-02-08 06:48:31 -0500 Release 0.08118 r23084@hlagh (orig r8587): ribasushi | 2010-02-08 06:52:33 -0500 Bump trunk version r23090@hlagh (orig r8593): ribasushi | 2010-02-08 10:16:44 -0500 cheaper lookup r23114@hlagh (orig r8596): ribasushi | 2010-02-10 06:40:37 -0500 Consolidate last_insert_id handling with a fallback-attempt on DBI::last_insert_id r23119@hlagh (orig r8601): caelum | 2010-02-10 15:29:51 -0500 workaround for Moose bug affecting Replicated storage r23120@hlagh (orig r8602): caelum | 2010-02-10 15:40:07 -0500 revert Moose bug workaround, bump Moose dep for Replicated to 0.98 r23121@hlagh (orig r8603): caelum | 2010-02-10 16:48:34 -0500 add a couple proxy methods to Replicated so it can run --- diff --git a/t/storage/replication.t b/t/storage/replication.t index c7485b4..5b74ab9 100644 --- a/t/storage/replication.t +++ b/t/storage/replication.t @@ -266,6 +266,56 @@ for my $method (qw/by_connect_info by_storage_type/) { => 'configured balancer_type'; } +### check that all Storage::DBI methods are handled by ::Replicated +{ + my @storage_dbi_methods = Class::MOP::Class + ->initialize('DBIx::Class::Storage::DBI')->get_all_method_names; + + my @replicated_methods = DBIx::Class::Storage::DBI::Replicated->meta + ->get_all_method_names; + +# remove constants and OTHER_CRAP + @storage_dbi_methods = grep !/^[A-Z_]+\z/, @storage_dbi_methods; + +# remove CAG accessors + @storage_dbi_methods = grep !/_accessor\z/, @storage_dbi_methods; + +# remove DBIx::Class (the root parent, with CAG and stuff) methods + my @root_methods = Class::MOP::Class->initialize('DBIx::Class') + ->get_all_method_names; + my %count; + $count{$_}++ for (@storage_dbi_methods, @root_methods); + + @storage_dbi_methods = grep $count{$_} != 2, @storage_dbi_methods; + +# make hashes + my %storage_dbi_methods; + @storage_dbi_methods{@storage_dbi_methods} = (); + my %replicated_methods; + @replicated_methods{@replicated_methods} = (); + +# remove ::Replicated-specific methods + for my $method (@replicated_methods) { + delete $replicated_methods{$method} + unless exists $storage_dbi_methods{$method}; + } + @replicated_methods = keys %replicated_methods; + +# check that what's left is implemented + %count = (); + $count{$_}++ for (@storage_dbi_methods, @replicated_methods); + + if ((grep $count{$_} == 2, @storage_dbi_methods) == @storage_dbi_methods) { + pass 'all DBIx::Class::Storage::DBI methods implemented'; + } + else { + my @unimplemented = grep $count{$_} == 1, @storage_dbi_methods; + + fail 'the following DBIx::Class::Storage::DBI methods are unimplemented: ' + . "@unimplemented"; + } +} + ok $replicated->schema->storage->meta => 'has a meta object';