From: Matt S Trout <mst@shadowcat.co.uk>
Date: Mon, 16 Apr 2012 16:48:31 +0000 (+0000)
Subject: re-kill evil hack
X-Git-Url: http://git.shadowcat.co.uk/gitweb/gitweb.cgi?a=commitdiff_plain;h=b841217ab824dddbbf040031284b260c9dee21b2;p=dbsrgits%2FDBIx-Class-Historic.git

re-kill evil hack
---

diff --git a/lib/DBIx/Class/ResultSet.pm b/lib/DBIx/Class/ResultSet.pm
index 3f7d18a..5434e1f 100644
--- a/lib/DBIx/Class/ResultSet.pm
+++ b/lib/DBIx/Class/ResultSet.pm
@@ -1893,7 +1893,7 @@ sub _rs_update_delete {
   # make a new $rs selecting only the PKs (that's all we really need for the subq)
   delete @{$attrs}{qw/collapse select _prefetch_selector_range as/};
   $attrs->{columns} = [ map { "$attrs->{alias}.$_" } @$idcols ];
-  $attrs->{group_by} = [];  # FIXME - this is an evil hack, it causes the optimiser to kick in and throw away the LEFT joins
+  #$attrs->{group_by} = [];  # FIXME - this is an evil hack, it causes the optimiser to kick in and throw away the LEFT joins
   my $subrs = (ref $self)->new($rsrc, $attrs);
 
   if (@$idcols == 1) {
diff --git a/t/52leaks.t b/t/52leaks.t
index a5ad085..7b51dc4 100644
--- a/t/52leaks.t
+++ b/t/52leaks.t
@@ -111,6 +111,7 @@ unless (DBICTest::RunMode->is_plain) {
   require DBI;
   require DBD::SQLite;
   require FileHandle;
+  require Moo;
 
   %$weak_registry = ();
 }