From: Peter Rabbitson <ribasushi@cpan.org>
Date: Sun, 22 Feb 2009 13:37:34 +0000 (+0000)
Subject: janitorial work
X-Git-Url: http://git.shadowcat.co.uk/gitweb/gitweb.cgi?a=commitdiff_plain;h=b818fc5dc8552b93b5b723ebff87b804b662d3dd;p=dbsrgits%2FDBIx-Class-Historic.git

janitorial work
---

diff --git a/Features_09 b/Features_09
index ba0e15f..24a6aa2 100644
--- a/Features_09
+++ b/Features_09
@@ -1,23 +1,17 @@
 (Potential) Features for 0.09
 =============================
 
-Subselects - everyone wants these
- - Will require new/improved SQL::Abstract
- - The API will involve passing ResultSets to searches as conditions/values/whatever.
-
 Row/find caching - would be pretty useful
  - Need to have good definitions of when the cache should be queried and when invalidated
  - Be able to supply own expiry?
  - Be able to invalidate manually? Single item / entire cache / single table
 
-Deprecate compose_connection / DB.pm
+Remove compose_connection / DB.pm
  - Everyone has probably forgotten what this is anyway..
 
 Syntax improvements?
  - "as" to "alias" ?
  - "belongs_to" to "contains/refers/something"
- - order_by to take a arrayref/hashref so it also just works with quoting
- - ??
 
 Using inflated objects/references as values in searches
  - Goes together with subselects above
@@ -52,15 +46,10 @@ Storage API/restructure
 Relationships
  - single vs filter, discrepancies.. remove one of them and make behave the same?
 
-SQL::Abstract et al
- - be able to extract/view/dump what the SQL is *going to* be before running it
- - bind params sanity? (order of bind params broken when using a resultsource based on a select statement)
- - etc
- 
 Joining/searching weird attribute tables?
  - Support legacy/badly designed junk better..
 
 Documentation - improvements
  - better indexing for finding of stuff in general
  - more cross-referencing of docs
- 
+
diff --git a/t/lib/DBICTest/Schema/CD.pm b/t/lib/DBICTest/Schema/CD.pm
index f222ff9..5638e24 100644
--- a/t/lib/DBICTest/Schema/CD.pm
+++ b/t/lib/DBICTest/Schema/CD.pm
@@ -82,10 +82,4 @@ __PACKAGE__->belongs_to('genre_inefficient', 'DBICTest::Schema::Genre',
     },
 );
 
-
-#__PACKAGE__->add_relationship('genre', 'DBICTest::Schema::Genre',
-#    { 'foreign.genreid' => 'self.genreid' },
-#    { 'accessor' => 'single' }
-#);
-
 1;