From: Peter Rabbitson Date: Wed, 18 Dec 2013 08:15:50 +0000 (+0100) Subject: Do not yell loudly on TODOified is_same_* tests X-Git-Url: http://git.shadowcat.co.uk/gitweb/gitweb.cgi?a=commitdiff_plain;h=b343752666c091274fe82eedeadcc39e64a7816c;hp=ff8ca6b4ad42a4b4d7adbfc89c820b48e2dd52c0;p=scpubgit%2FQ-Branch.git Do not yell loudly on TODOified is_same_* tests --- diff --git a/lib/SQL/Abstract/Test.pm b/lib/SQL/Abstract/Test.pm index 202d130..c802be1 100644 --- a/lib/SQL/Abstract/Test.pm +++ b/lib/SQL/Abstract/Test.pm @@ -82,17 +82,21 @@ sub is_same_bind { sub _sql_differ_diag { my ($sql1, $sql2) = @_; - $tb->diag("SQL expressions differ\n" + $tb->${\( $tb->in_todo ? 'note' : 'diag')} ( + "SQL expressions differ\n" ." got: $sql1\n" ."expected: $sql2\n" ."differing in :\n$sql_differ\n" - ); + ); } sub _bind_differ_diag { my ($bind_ref1, $bind_ref2) = @_; - $tb->diag("BIND values differ\n" + local $Data::Dumper::Maxdepth; + + $tb->${\( $tb->in_todo ? 'note' : 'diag')} ( + "BIND values differ\n" ." got: " . Dumper($bind_ref1) ."expected: " . Dumper($bind_ref2) );