From: Dave Rolsky Date: Thu, 21 Aug 2008 15:23:38 +0000 (+0000) Subject: no more perl critic X-Git-Tag: 0.06_01~10 X-Git-Url: http://git.shadowcat.co.uk/gitweb/gitweb.cgi?a=commitdiff_plain;h=b210d8fbbd36792aca6a7e75dbbc81fd4303aa88;p=gitmo%2FMooseX-StrictConstructor.git no more perl critic --- diff --git a/lib/MooseX/StrictConstructor/Meta/Method/Constructor.pm b/lib/MooseX/StrictConstructor/Meta/Method/Constructor.pm index 06d5b10..19547d3 100644 --- a/lib/MooseX/StrictConstructor/Meta/Method/Constructor.pm +++ b/lib/MooseX/StrictConstructor/Meta/Method/Constructor.pm @@ -8,7 +8,7 @@ use Moose; extends 'Moose::Meta::Method::Constructor'; -override '_generate_BUILDALL' => sub ## no critic RequireArgUnpacking +override '_generate_BUILDALL' => sub { my $self = shift; diff --git a/lib/MooseX/StrictConstructor/Role/Metaclass.pm b/lib/MooseX/StrictConstructor/Role/Metaclass.pm index 76505d8..d2c0239 100644 --- a/lib/MooseX/StrictConstructor/Role/Metaclass.pm +++ b/lib/MooseX/StrictConstructor/Role/Metaclass.pm @@ -8,7 +8,7 @@ use MooseX::StrictConstructor::Meta::Method::Constructor; use Moose::Role; -around 'make_immutable' => sub ## no critic RequireArgUnpacking +around 'make_immutable' => sub { my $orig = shift; my $self = shift; diff --git a/t/perlcritic.t b/t/perlcritic.t deleted file mode 100644 index 178d939..0000000 --- a/t/perlcritic.t +++ /dev/null @@ -1,13 +0,0 @@ -use strict; -use warnings; - -use Test::More; - - -plan skip_all => 'This test is only run for the module author' - unless -d '.svn' || $ENV{IS_MAINTAINER}; - -eval 'use Test::Perl::Critic ( -severity => 4 )'; -plan skip_all => 'Test::Perl::Critic required for criticizing' if $@; - -all_critic_ok();