From: Nicholas Clark Date: Sat, 3 Jan 2009 10:38:28 +0000 (+0000) Subject: get_isa_hash() is only used in S_isa_lookup(), so it can be static. Also, it has X-Git-Url: http://git.shadowcat.co.uk/gitweb/gitweb.cgi?a=commitdiff_plain;h=aea323039bd02667df3bd60d27358d65842cd171;p=p5sagit%2Fp5-mst-13.2.git get_isa_hash() is only used in S_isa_lookup(), so it can be static. Also, it has never been in a released version of perl, so this change has no compatibility implications. --- diff --git a/embed.fnc b/embed.fnc index 749b975..1a053e8 100644 --- a/embed.fnc +++ b/embed.fnc @@ -2218,8 +2218,7 @@ ApoM |const char *|fetch_cop_label|NULLOK struct refcounted_he *const chain \ : Only used in op.c xpoM |struct refcounted_he *|store_cop_label \ |NULLOK struct refcounted_he *const chain|NN const char *label -: Only used in univeral.c -poM |HV * |get_isa_hash |NN HV *const stash +so |HV * |get_isa_hash |NN HV *const stash END_EXTERN_C /* diff --git a/proto.h b/proto.h index b292f2e..1efa37e 100644 --- a/proto.h +++ b/proto.h @@ -6649,7 +6649,7 @@ PERL_CALLCONV struct refcounted_he * Perl_store_cop_label(pTHX_ struct refcounte #define PERL_ARGS_ASSERT_STORE_COP_LABEL \ assert(label) -PERL_CALLCONV HV * Perl_get_isa_hash(pTHX_ HV *const stash) +STATIC HV * S_get_isa_hash(pTHX_ HV *const stash) __attribute__nonnull__(pTHX_1); #define PERL_ARGS_ASSERT_GET_ISA_HASH \ assert(stash) diff --git a/universal.c b/universal.c index a748d45..d333d23 100644 --- a/universal.c +++ b/universal.c @@ -33,8 +33,8 @@ #include "perliol.h" /* For the PERLIO_F_XXX */ #endif -HV * -Perl_get_isa_hash(pTHX_ HV *const stash) +static HV * +S_get_isa_hash(pTHX_ HV *const stash) { dVAR; struct mro_meta *const meta = HvMROMETA(stash); @@ -78,7 +78,7 @@ S_isa_lookup(pTHX_ HV *stash, const char * const name) { dVAR; const struct mro_meta *const meta = HvMROMETA(stash); - HV *const isa = meta->isa ? meta->isa : Perl_get_isa_hash(aTHX_ stash); + HV *const isa = meta->isa ? meta->isa : S_get_isa_hash(aTHX_ stash); STRLEN len = strlen(name); const HV *our_stash;