From: Tomas Doran <bobtfish@bobtfish.net>
Date: Thu, 4 Aug 2011 22:21:34 +0000 (+0100)
Subject: Comments
X-Git-Url: http://git.shadowcat.co.uk/gitweb/gitweb.cgi?a=commitdiff_plain;h=adef3d1994a8b02153e7df53bf600231f9c41789;p=catagits%2FCatalyst-Runtime.git

Comments
---

diff --git a/t/lib/TestAppCustomContainer/NoSugarContainer.pm b/t/lib/TestAppCustomContainer/NoSugarContainer.pm
index 6abc3d6..13721b8 100644
--- a/t/lib/TestAppCustomContainer/NoSugarContainer.pm
+++ b/t/lib/TestAppCustomContainer/NoSugarContainer.pm
@@ -39,7 +39,8 @@ sub BUILD {
         Catalyst::IOC::ConstructorInjection->new(
             name         => 'model_Baz',
             class        => 'TestAppCustomContainer::Model::Baz',
-
+# t0m - I'm fine with this - sugar can just s/Request/+Catalyst::IOC::LifeCycle::Request/
+#       Also, 'Request' is fine as a name for a lifecycle IMO.
 # FIXME - it should simply be Request (or InstancePerRequest, etc)
 # see Bread/Board/Service.pm line 47
             lifecycle    => '+Catalyst::IOC::LifeCycle::Request',
@@ -72,6 +73,7 @@ sub BUILD {
 
 # FIXME - it should probably be our
 # Catalyst::IOC::LifeCycle::Singleton
+# t0m - I think normal Singleton is fine here, it's per app lifetime.
             lifecycle    => 'Singleton',
             dependencies => [
                 depends_on( '/component/model_Quux' ),