From: Peter Rabbitson Date: Tue, 17 Mar 2015 15:21:47 +0000 (+0100) Subject: Fix exception on complex update/delete under a replicated setup X-Git-Url: http://git.shadowcat.co.uk/gitweb/gitweb.cgi?a=commitdiff_plain;h=adc715e3c685ec81f9a000ce88c19f33736557e8;p=dbsrgits%2FDBIx-Class-Historic.git Fix exception on complex update/delete under a replicated setup THIS COMMIT IS A HACK!!! The actual fix is migration of the logic to the SQLMaker subclass and deal with it there. However the entire class hierarchy is currently in flux, so go with the least invasive change until the storage rewrite settles. (cherry pick of 7f95ea99) --- diff --git a/Changes b/Changes index 1821b49..df010f4 100644 --- a/Changes +++ b/Changes @@ -5,6 +5,8 @@ Revision history for DBIx::Class resolution codepath, restoring exotic uses of inflate_result http://lists.scsys.co.uk/pipermail/dbix-class/2015-January/011876.html - Fix updating multiple CLOB/BLOB columns on Oracle + - Fix exception on complex update/delete under a replicated setup + http://lists.scsys.co.uk/pipermail/dbix-class/2015-January/011903.html * Misc - Remove warning about potential side effects of RT#79576 (scheduled) diff --git a/lib/DBIx/Class/Storage/DBI/Replicated.pm b/lib/DBIx/Class/Storage/DBI/Replicated.pm index 70fd834..6b1181e 100644 --- a/lib/DBIx/Class/Storage/DBI/Replicated.pm +++ b/lib/DBIx/Class/Storage/DBI/Replicated.pm @@ -307,6 +307,7 @@ my $method_dispatch = { _parse_connect_do savepoints _sql_maker_opts + _use_multicolumn_in _conn_pid _dbh_autocommit _native_data_type @@ -363,7 +364,7 @@ my $method_dispatch = { # the capability framework # not sure if CMOP->initialize does evil things to DBIC::S::DBI, fix if a problem grep - { $_ =~ /^ _ (?: use | supports | determine_supports ) _ /x } + { $_ =~ /^ _ (?: use | supports | determine_supports ) _ /x and $_ ne '_use_multicolumn_in' } ( Class::MOP::Class->initialize('DBIx::Class::Storage::DBI')->get_all_method_names ) )], };