From: Shawn M Moore <sartak@gmail.com>
Date: Tue, 28 Apr 2009 09:42:50 +0000 (-0400)
Subject: RequireMakeImmutable policy
X-Git-Url: http://git.shadowcat.co.uk/gitweb/gitweb.cgi?a=commitdiff_plain;h=ad350a21dbf83cadd383acc4ad806c1535243fc3;p=gitmo%2FPerl-Critic-Dynamic-Moose.git

RequireMakeImmutable policy
---

diff --git a/lib/Perl/Critic/Policy/DynamicMoose/RequireMakeImmutable.pm b/lib/Perl/Critic/Policy/DynamicMoose/RequireMakeImmutable.pm
new file mode 100644
index 0000000..44c297d
--- /dev/null
+++ b/lib/Perl/Critic/Policy/DynamicMoose/RequireMakeImmutable.pm
@@ -0,0 +1,54 @@
+package Perl::Critic::Policy::DynamicMoose::RequireMakeImmutable;
+use Moose;
+extends 'Perl::Critic::Policy::DynamicMoose';
+
+use Perl::Critic::Utils ':severities';
+use Perl::Critic::Utils::Moose 'meta_type';
+
+Readonly::Scalar my $EXPL => q{Moose can't optimize itself if classes remain mutable.};
+sub default_severity { $SEVERITY_HIGH }
+
+sub violates_metaclass {
+    my $self = shift;
+    my $meta = shift;
+
+    return if $meta->is_immutable;
+
+    my $desc = "The " . $meta->name . " " . meta_type($meta) . " was not made immutable.";
+
+    return $self->violation($desc, $EXPL);
+}
+
+no Moose;
+
+1;
+
+__END__
+
+=head1 NAME
+
+Perl::Critic::Policy::DynamicMoose::RequireMakeImmutable
+
+=head1 DESCRIPTION
+
+
+=head1 WARNING
+
+B<VERY IMPORTANT:> Most L<Perl::Critic> Policies (including all the ones that
+ship with Perl::Critic> use pure static analysis -- they never compile nor
+execute any of the code that they analyze.  However, this policy is very
+different.  It actually attempts to compile your code and then compares the
+subroutines mentioned in your code to those found in the symbol table.
+Therefore you should B<not> use this Policy on any code that you do not trust,
+or may have undesirable side-effects at compile-time (such as connecting to the
+network or mutating files).
+
+For this Policy to work, all the modules included in your code must be
+installed locally, and must compile without error.
+
+=head1 AUTHOR
+
+Shawn M Moore, C<sartak@bestpractical.com>
+
+=cut
+
diff --git a/t/DynamicMoose/RequireMakeImmutable.run b/t/DynamicMoose/RequireMakeImmutable.run
new file mode 100644
index 0000000..08a3622
--- /dev/null
+++ b/t/DynamicMoose/RequireMakeImmutable.run
@@ -0,0 +1,39 @@
+## name Makes immutable
+## failures 0
+## cut
+
+package Class;
+use Moose;
+
+has attr => (
+    is => 'rw',
+);
+
+__PACKAGE__->meta->make_immutable;
+
+#-----------------------------------------------------------------------------
+
+## name Does not make immutable
+## failures 1
+## cut
+
+package Class;
+use Moose;
+
+has attr => (
+    is => 'rw',
+    builder => '_build_attr',
+);
+
+#-----------------------------------------------------------------------------
+
+## name Does not statically make immutable
+## failures 0
+## cut
+
+for (1 .. 5) {
+    my $class = Class::MOP::Class->create("Foo$_");
+    my $method = join '_', "make", "immutable";
+    $class->$method;
+}
+