From: Craig A. Berry <craigberry@mac.com>
Date: Sun, 25 Feb 2007 00:54:14 +0000 (+0000)
Subject: Add a comment to mg.c to clarify that words like "raise" and
X-Git-Url: http://git.shadowcat.co.uk/gitweb/gitweb.cgi?a=commitdiff_plain;h=acd15b85995cf95382f158dbf237ef9c2ee99b7b;p=p5sagit%2Fp5-mst-13.2.git

Add a comment to mg.c to clarify that words like "raise" and
"pending" in the context of Perl's deferred signals bear only
an analogous relationship to the underlying signal mechanism.

p4raw-id: //depot/perl@30393
---

diff --git a/mg.c b/mg.c
index 47d9cb4..b9b2ca2 100644
--- a/mg.c
+++ b/mg.c
@@ -1278,6 +1278,19 @@ Perl_magic_clearsig(pTHX_ SV *sv, MAGIC *mg)
     return 0;
 }
 
+/*
+ * The signal handling nomenclature has gotten a bit confusing since the advent of
+ * safe signals.  S_raise_signal only raises signals by analogy with what the 
+ * underlying system's signal mechanism does.  It might be more proper to say that
+ * it defers signals that have already been raised and caught.  
+ *
+ * PL_sig_pending and PL_psig_pend likewise do not track signals that are pending 
+ * in the sense of being on the system's signal queue in between raising and delivery.  
+ * They are only pending on Perl's deferral list, i.e., they track deferred signals 
+ * awaiting delivery after the current Perl opcode completes and say nothing about
+ * signals raised but not yet caught in the underlying signal implementation.
+ */
+
 #ifndef SIG_PENDING_DIE_COUNT
 #  define SIG_PENDING_DIE_COUNT 120
 #endif