From: Jesse Luehrs Date: Tue, 29 Nov 2011 20:49:26 +0000 (-0600) Subject: don't rely on the ::PP BROKEN_ constants existing in tests X-Git-Url: http://git.shadowcat.co.uk/gitweb/gitweb.cgi?a=commitdiff_plain;h=acbc69c4f1ade78eb1d6f951cb6336af4297d996;p=gitmo%2FPackage-Stash.git don't rely on the ::PP BROKEN_ constants existing in tests --- diff --git a/t/anon-basic.t b/t/anon-basic.t index bfa80e1..fc26f12 100644 --- a/t/anon-basic.t +++ b/t/anon-basic.t @@ -10,7 +10,7 @@ use Package::Stash; use Symbol; plan skip_all => "Anonymous stashes in PP need at least perl 5.14" - if Package::Stash::BROKEN_GLOB_ASSIGNMENT + if $] < 5.014 && $Package::Stash::IMPLEMENTATION eq 'PP'; my $Foo = Package::Anon->new('Foo'); diff --git a/t/anon.t b/t/anon.t index 575de06..8b7f7aa 100644 --- a/t/anon.t +++ b/t/anon.t @@ -11,7 +11,7 @@ use Package::Stash; use Symbol; plan skip_all => "Anonymous stashes in PP need at least perl 5.14" - if Package::Stash::BROKEN_GLOB_ASSIGNMENT + if $] < 5.014 && $Package::Stash::IMPLEMENTATION eq 'PP'; my $anon = Package::Anon->new; diff --git a/t/bare-anon-basic.t b/t/bare-anon-basic.t index 3291cd3..9cea31e 100644 --- a/t/bare-anon-basic.t +++ b/t/bare-anon-basic.t @@ -9,7 +9,7 @@ use Package::Stash; use Symbol; plan skip_all => "Anonymous stashes in PP need at least perl 5.14" - if Package::Stash::BROKEN_GLOB_ASSIGNMENT + if $] < 5.014 && $Package::Stash::IMPLEMENTATION eq 'PP'; my $Foo = {}; diff --git a/t/bare-anon.t b/t/bare-anon.t index e24647d..34e234c 100644 --- a/t/bare-anon.t +++ b/t/bare-anon.t @@ -9,7 +9,7 @@ use Package::Stash; use Symbol; plan skip_all => "Anonymous stashes in PP need at least perl 5.14" - if Package::Stash::BROKEN_GLOB_ASSIGNMENT + if $] < 5.014 && $Package::Stash::IMPLEMENTATION eq 'PP'; my $anon = {}; diff --git a/t/edge-cases.t b/t/edge-cases.t index 1d26176..d1e5182 100755 --- a/t/edge-cases.t +++ b/t/edge-cases.t @@ -55,8 +55,7 @@ is(ref($stash->get_or_add_symbol('$glob')), 'SCALAR', "got an empty scalar"); SKIP: { skip "PP doesn't support anon stashes before 5.14", 4 - if $Package::Stash::IMPLEMENTATION eq 'PP' - && Package::Stash::BROKEN_GLOB_ASSIGNMENT; + if $] < 5.014 && $Package::Stash::IMPLEMENTATION eq 'PP'; local $TODO = ($Package::Stash::IMPLEMENTATION eq 'PP') ? "don't know how to properly inflate a stash entry" : undef;