From: Gurusamy Sarathy <gsar@cpan.org>
Date: Fri, 10 Jul 1998 20:19:18 +0000 (+0000)
Subject: inet_aton() should do DNS lookup only if arg isn't a dotted-quad
X-Git-Url: http://git.shadowcat.co.uk/gitweb/gitweb.cgi?a=commitdiff_plain;h=ac9fe1c23eac5f442f32542eeea699c9f084bf60;p=p5sagit%2Fp5-mst-13.2.git

inet_aton() should do DNS lookup only if arg isn't a dotted-quad
(suggested by Philippe.Simonet@swisscom.com)

p4raw-id: //depot/perl@1402
---

diff --git a/ext/Socket/Socket.xs b/ext/Socket/Socket.xs
index 82ed442..cefcb24 100644
--- a/ext/Socket/Socket.xs
+++ b/ext/Socket/Socket.xs
@@ -711,13 +711,11 @@ inet_aton(host)
 	{
 	struct in_addr ip_address;
 	struct hostent * phe;
-	int ok;
+	int ok = inet_aton(host, &ip_address);
 
-	if (phe = gethostbyname(host)) {
+	if (!ok && (phe = gethostbyname(host))) {
 		Copy( phe->h_addr, &ip_address, phe->h_length, char );
 		ok = 1;
-	} else {
-		ok = inet_aton(host, &ip_address);
 	}
 
 	ST(0) = sv_newmortal();