From: Nicholas Clark <nick@ccl4.org>
Date: Mon, 13 Apr 2009 10:22:11 +0000 (+0100)
Subject: Correct two other tests that apparently should be TODOs rather than SKIPs.
X-Git-Url: http://git.shadowcat.co.uk/gitweb/gitweb.cgi?a=commitdiff_plain;h=ac0f141316dd2d480f004051c0f60946e2b6e87c;p=p5sagit%2Fp5-mst-13.2.git

Correct two other tests that apparently should be TODOs rather than SKIPs.
---

diff --git a/ext/B/t/deparse.t b/ext/B/t/deparse.t
index a1c4a9b..2404202 100644
--- a/ext/B/t/deparse.t
+++ b/ext/B/t/deparse.t
@@ -550,8 +550,10 @@ do {
 '???';
 !1;
 ####
-# SKIP ? $Config::Config{useithreads} && "TODO doesn't work with threads"
+# TODO ? $Config::Config{useithreads} && "doesn't work with threads"
 # 61 tests that shouldn't be constant folded
+# It might be fundamentally impossible to make this work on ithreads, in which
+# case the TODO should become a SKIP
 x() if $a;
 if ($a == 1) { x() } elsif ($b == 2) { z() }
 if (do { foo(); GLIPP }) { x() }
@@ -574,8 +576,10 @@ warn O_CREAT;
 # 65 tests for deparsing imported constants that got deleted from the original namespace
 warn O_APPEND;
 ####
-# SKIP ? $Config::Config{useithreads} && "TODO doesn't work with threads"
+# TODO ? $Config::Config{useithreads} && "doesn't work with threads"
 # 66 tests for deparsing constants which got turned into full typeglobs
+# It might be fundamentally impossible to make this work on ithreads, in which
+# case the TODO should become a SKIP
 warn O_EXCL;
 eval '@Fcntl::O_EXCL = qw/affe tiger/;';
 warn O_EXCL;