From: Rafael Kitover Date: Sat, 9 Apr 2011 13:00:47 +0000 (-0400) Subject: Remove use of _resolve_column_info call from _prep_for_execute in NoBindVars X-Git-Url: http://git.shadowcat.co.uk/gitweb/gitweb.cgi?a=commitdiff_plain;h=abe9977d3d930c8a8e86cf817b717e60d5a9460f;p=dbsrgits%2FDBIx-Class-Historic.git Remove use of _resolve_column_info call from _prep_for_execute in NoBindVars Use the datatype as passed via the bind attribute resolution --- diff --git a/lib/DBIx/Class/Storage/DBI/NoBindVars.pm b/lib/DBIx/Class/Storage/DBI/NoBindVars.pm index 71de5b9..a5eb1ab 100644 --- a/lib/DBIx/Class/Storage/DBI/NoBindVars.pm +++ b/lib/DBIx/Class/Storage/DBI/NoBindVars.pm @@ -49,20 +49,16 @@ sub _prep_for_execute { my @sql_part = split /\?/, $sql; my $new_sql; - my $col_info = $self->_resolve_column_info( - $ident, [ map { $_->[0]{dbic_colname} || () } @$bind ] - ); - for (@$bind) { - my $datatype = $col_info->{ $_->[0]{dbic_colname}||'' }{data_type}; + my $data = (ref $_->[1]) ? "$_->[1]" : $_->[1]; # always stringify, array types are currently not supported - my $data = (ref $_->[1]) ? "$_->[1]" : $_->[1]; # always stringify + my $datatype = $_->[0]{sqlt_datatype}; $data = $self->_prep_interpolated_value($datatype, $data) if $datatype; $data = $self->_get_dbh->quote($data) - unless $self->interpolate_unquoted($datatype, $data); + unless ($datatype and $self->interpolate_unquoted($datatype, $data) ); $new_sql .= shift(@sql_part) . $data; }