From: Stevan Little <stevan.little@iinteractive.com>
Date: Sun, 15 Jul 2007 17:50:43 +0000 (+0000)
Subject: 0.05
X-Git-Tag: 0_07~10
X-Git-Url: http://git.shadowcat.co.uk/gitweb/gitweb.cgi?a=commitdiff_plain;h=a7f358fb48a26700a3683db2a10a12660cf4a189;p=gitmo%2FMooseX-Storage.git

0.05
---

diff --git a/Changes b/Changes
index a03e6a7..79b94b8 100644
--- a/Changes
+++ b/Changes
@@ -1,5 +1,16 @@
 Revision history for MooseX-Storage
 
+0.05 Sun. July 15. 2007
+    * MooseX::Storage::Base::WithChecksum
+      - Fixed minor issue where the WithChecksum would 
+        choke with a bad checksum due to odd Data::Dumper
+        output.
+    
+    * t/
+      - forced JSON::Any in the basic JSON tests to use 
+        JSON.pm since this is what Test::JSON uses and 
+        subtle (and annoying) issues can arise.
+
 0.04 Tues. July 3, 2007
     * MooseX::Storage::Util
         - made this more robust when it tries
diff --git a/lib/MooseX/Storage.pm b/lib/MooseX/Storage.pm
index bcd2761..6b8cf34 100644
--- a/lib/MooseX/Storage.pm
+++ b/lib/MooseX/Storage.pm
@@ -4,7 +4,7 @@ use Moose qw(confess);
 
 use MooseX::Storage::Meta::Attribute::DoNotSerialize;
 
-our $VERSION   = '0.04';
+our $VERSION   = '0.05';
 our $AUTHORITY = 'cpan:STEVAN';
 
 sub import {
diff --git a/lib/MooseX/Storage/Base/WithChecksum.pm b/lib/MooseX/Storage/Base/WithChecksum.pm
index cf1ebdf..0f1292d 100644
--- a/lib/MooseX/Storage/Base/WithChecksum.pm
+++ b/lib/MooseX/Storage/Base/WithChecksum.pm
@@ -7,7 +7,7 @@ use Data::Dumper ();
 
 use MooseX::Storage::Engine;
 
-our $VERSION   = '0.01';
+our $VERSION   = '0.02';
 our $AUTHORITY = 'cpan:STEVAN';
 
 our $DIGEST_MARKER = '__DIGEST__';
@@ -53,7 +53,13 @@ sub _digest_packed {
         local $Data::Dumper::Useqq    = 0;
         local $Data::Dumper::Deparse  = 0; # FIXME?
         my $str = Data::Dumper::Dumper($collapsed);
-        $str =~ s/(?<! ['"] ) \b (\d+) \b (?! ['"] )/'$1'/gx; # canonicalize numbers to strings even if it mangles numbers inside strings
+        # NOTE:
+        # Canonicalize numbers to strings even if it 
+        # mangles numbers inside strings. It really 
+        # does not matter since its just the checksum
+        # anyway.
+        # - YK/SL
+        $str =~ s/(?<! ['"] ) \b (\d+) \b (?! ['"] )/'$1'/gx; 
         $d->add( $str );
     }
 
diff --git a/t/010_basic_json.t b/t/010_basic_json.t
index a410b13..30b3327 100644
--- a/t/010_basic_json.t
+++ b/t/010_basic_json.t
@@ -7,7 +7,13 @@ use Test::More;
 
 BEGIN {
     eval "use Test::JSON";
-    plan skip_all => "Test::JSON is required for this test" if $@;        
+    plan skip_all => "Test::JSON is required for this test" if $@; 
+    # NOTE: 
+    # this idiocy is cause Test::JSON 
+    # uses JSON.pm and that can be 
+    # very picky about the JSON output
+    # - SL 
+    BEGIN { $ENV{JSON_ANY_ORDER} = qw(JSON) }           
     plan tests => 12;
     use_ok('MooseX::Storage');
 }
diff --git a/t/030_with_checksum.t b/t/030_with_checksum.t
index 407e2fd..fc655e2 100644
--- a/t/030_with_checksum.t
+++ b/t/030_with_checksum.t
@@ -9,7 +9,7 @@ use Test::Deep;
 
 BEGIN {
     eval "use Digest; use Digest::SHA1";
-    plan skip_all => "Digest and Digest::SHA1 is required for this test" if $@;        
+    plan skip_all => "Digest and Digest::SHA1 is required for this test" if $@;           
     plan tests => 26;
     use_ok('MooseX::Storage');
 }