From: Jarkko Hietaniemi <jhi@iki.fi>
Date: Tue, 19 Sep 2006 09:19:22 +0000 (+0300)
Subject: C++: add -Wno-used-parameter, and drop ODBM_File
X-Git-Url: http://git.shadowcat.co.uk/gitweb/gitweb.cgi?a=commitdiff_plain;h=a7ae1e4a956bbd5ffa44d286e0591bf4c0e7c341;p=p5sagit%2Fp5-mst-13.2.git

C++: add -Wno-used-parameter, and drop ODBM_File
Message-ID: <450F8BEA.1010802@iki.fi>

p4raw-id: //depot/perl@28867
---

diff --git a/Makefile.SH b/Makefile.SH
index 999bd95..17e9fe7 100644
--- a/Makefile.SH
+++ b/Makefile.SH
@@ -156,6 +156,13 @@ esac
 : Prepare dependency lists for Makefile.
 dynamic_list=' '
 extra_dep=''
+case "$d_cplusplus" in
+define)
+  : delete as a function name will not work.
+  dynamic_ext=`echo $dynamic_ext | sed 's/ODBM_File//'`
+  static_ext=`echo $static_ext | sed 's/ODBM_File//'`
+  ;;
+esac
 for f in $dynamic_ext; do
     : the dependency named here will never exist
       base=`echo "$f" | sed 's/.*\///'`
diff --git a/cflags.SH b/cflags.SH
index 966901a..95f846b 100755
--- a/cflags.SH
+++ b/cflags.SH
@@ -234,10 +234,14 @@ esac
 case "$cc" in
 *g++*)
   # Without -Wno-unused-variable g++ 4.x compiles are rather unwatchable
-  # because of all the warnings about Perl___notused, and g++ doesn't
-  # do __attribute__((unused)) (and even if at some stage it will), people
-  # do have older gcc installations.  Yes, we lose some valid warnings.
-  for o in -Wno-unused-variable
+  # because of all the warnings about Perl___notused, and g++ doesn't do
+  # __attribute__((unused)) (and even if at some stage it may, people do
+  # have older gcc installations), and ((void)x) isn't enough to silence
+  # the noises about XS functions not using their cv parameter, so we need
+  # the -Wno-unused-parameter too.
+  # Yes, we lose some valid warnings, but hopefully other compilers
+  # (like gcc) will still pick up those warnings.
+  for o in -Wno-unused-variable -Wno-unused-parameter
   do
     case "$warn" in
     *$o*) ;;