From: Peter Rabbitson <ribasushi@cpan.org>
Date: Fri, 27 Dec 2013 16:32:15 +0000 (+0100)
Subject: Smarter todoification (this doesn't sound like a bad idea for CPAN in general)
X-Git-Url: http://git.shadowcat.co.uk/gitweb/gitweb.cgi?a=commitdiff_plain;h=a63c42fc0b2844ff59bc86719fbe2c779067f171;p=dbsrgits%2FDBIx-Class.git

Smarter todoification (this doesn't sound like a bad idea for CPAN in general)

The remaining failing tests are *real* fails and need addressing
---

diff --git a/.auto_todo b/.auto_todo
new file mode 100644
index 0000000..966b837
--- /dev/null
+++ b/.auto_todo
@@ -0,0 +1,18 @@
+# *unless* any of the following variables are set:
+# RELEASE_TESTING
+# AUTHOR_TESTING
+# Any non-commented-out filename in this list will be executed in
+# "todo mode"
+#
+# Names are matched via
+#
+#  $0 =~ m! (?: \A | / ) \Q$chomped_name_as_seen_in_this_file\E \z !x
+#
+
+# blocked on Carp::Skip
+t/sqlmaker/bind_transport.t
+t/sqlmaker/nest_deprec.t
+t/sqlmaker/core.t
+
+# waiting on riba - the leak detection mechanism has issues here and there
+t/52leaks.t
diff --git a/.gitignore b/.gitignore
index 233a2fb..5628398 100644
--- a/.gitignore
+++ b/.gitignore
@@ -19,4 +19,4 @@ t/var/
 *~
 maint/.Generated_Pod
 examples/Schema/db
-lib/DBIx/Class/_TempExtlib
\ No newline at end of file
+lib/DBIx/Class/_TempExtlib
diff --git a/lib/DBIx/Class/Storage/DBI/Replicated.pm b/lib/DBIx/Class/Storage/DBI/Replicated.pm
index 70e4980..91ce826 100644
--- a/lib/DBIx/Class/Storage/DBI/Replicated.pm
+++ b/lib/DBIx/Class/Storage/DBI/Replicated.pm
@@ -345,6 +345,8 @@ my $method_dispatch = {
     sql_quote_char
     sql_name_sep
 
+    perl_renderer
+
     _prefetch_autovalues
     _perform_autoinc_retrieval
     _autoinc_supplied_for_op
diff --git a/t/52leaks.t b/t/52leaks.t
index 683d543..4923be0 100644
--- a/t/52leaks.t
+++ b/t/52leaks.t
@@ -21,8 +21,6 @@ use strict;
 use warnings;
 use Test::More;
 
-local $TODO = 'Temporarily todo-ed for dq2eb';
-
 my $TB = Test::More->builder;
 if ($ENV{DBICTEST_IN_PERSISTENT_ENV}) {
   # without this explicit close older TBs warn in END after a ->reset
diff --git a/t/lib/DBICTest.pm b/t/lib/DBICTest.pm
index c75a077..8b72950 100644
--- a/t/lib/DBICTest.pm
+++ b/t/lib/DBICTest.pm
@@ -21,6 +21,32 @@ BEGIN {
   }
 }
 
+# This is a pretty good candidate for a standalone extraction (Test::AutoSkip?)
+BEGIN {
+  if (
+    ! $ENV{RELEASE_TESTING}
+      and
+    ! $ENV{AUTHOR_TESTING}
+      and
+    $0 =~ /^ (.*) x?t [\/\\] .+ \.t $/x
+      and
+    -f ( my $fn = "$1.auto_todo")
+  ) {
+    # fuck you win32
+    require File::Spec;
+    my $canonical_dollarzero = File::Spec::Unix->catpath(File::Spec->splitpath($0));
+
+    for my $t ( map {
+      ( $_ =~ /^ \s* ( [^\#\n]+ ) /x ) ? $1 : ()
+    } do { local @ARGV = $fn; <> } ) {
+      if ( $canonical_dollarzero =~ m! (?: \A | / ) \Q$t\E \z !x ) {
+        require Test::Builder;
+        Test::Builder->new->todo_start("Global todoification of '$t' specified in $fn");
+      }
+    }
+  }
+}
+
 use Module::Runtime 'module_notional_filename';
 BEGIN {
   for my $mod (qw( DBIC::SqlMakerTest SQL::Abstract )) {
diff --git a/t/sqlmaker/bind_transport.t b/t/sqlmaker/bind_transport.t
index da1176b..bafe8e9 100644
--- a/t/sqlmaker/bind_transport.t
+++ b/t/sqlmaker/bind_transport.t
@@ -5,8 +5,6 @@ use Test::More;
 use Test::Exception;
 use Math::BigInt;
 
-local $TODO = 'Temporarily todo-ed for dq2eb';
-
 use lib qw(t/lib);
 use DBICTest;
 use DBIC::SqlMakerTest;
diff --git a/t/sqlmaker/core.t b/t/sqlmaker/core.t
index e534269..57cf480 100644
--- a/t/sqlmaker/core.t
+++ b/t/sqlmaker/core.t
@@ -4,8 +4,6 @@ use warnings;
 use Test::More;
 use Test::Exception;
 
-local $TODO = 'Temporarily todo-ed for dq2eb';
-
 use lib qw(t/lib);
 use DBICTest;
 use DBIC::SqlMakerTest;
diff --git a/t/sqlmaker/core_quoted.t b/t/sqlmaker/core_quoted.t
index f02cf0d..53ce03b 100644
--- a/t/sqlmaker/core_quoted.t
+++ b/t/sqlmaker/core_quoted.t
@@ -3,8 +3,6 @@ use warnings;
 
 use Test::More;
 
-local $TODO = 'Temporarily todo-ed for dq2eb';
-
 use lib qw(t/lib);
 use DBICTest;
 use DBIC::SqlMakerTest;
diff --git a/t/sqlmaker/limit_dialects/generic_subq.t b/t/sqlmaker/limit_dialects/generic_subq.t
index f1e2fcb..c94942e 100644
--- a/t/sqlmaker/limit_dialects/generic_subq.t
+++ b/t/sqlmaker/limit_dialects/generic_subq.t
@@ -2,9 +2,6 @@ use strict;
 use warnings;
 
 use Test::More;
-
-local $TODO = 'Temporarily todo-ed for dq2eb';
-
 use lib qw(t/lib);
 use List::Util 'min';
 use DBICTest;
diff --git a/t/sqlmaker/limit_dialects/torture.t b/t/sqlmaker/limit_dialects/torture.t
index 11fb6a0..6671e37 100644
--- a/t/sqlmaker/limit_dialects/torture.t
+++ b/t/sqlmaker/limit_dialects/torture.t
@@ -2,9 +2,6 @@ use strict;
 use warnings;
 
 use Test::More;
-
-local $TODO = 'Temporarily todo-ed for dq2eb';
-
 use Test::Exception;
 use Storable 'dclone';
 use lib qw(t/lib);
diff --git a/t/sqlmaker/nest_deprec.t b/t/sqlmaker/nest_deprec.t
index f1fd693..f00443a 100644
--- a/t/sqlmaker/nest_deprec.t
+++ b/t/sqlmaker/nest_deprec.t
@@ -4,8 +4,6 @@ use warnings;
 use Test::More;
 use Test::Warn;
 
-local $TODO = 'Temporarily todo-ed for dq2eb';
-
 use lib qw(t/lib);
 use DBICTest;
 use DBIC::SqlMakerTest;
diff --git a/t/storage/replicated.t b/t/storage/replicated.t
index 644a934..dfd3870 100644
--- a/t/storage/replicated.t
+++ b/t/storage/replicated.t
@@ -3,8 +3,6 @@ use warnings;
 
 use Test::More;
 
-local $TODO = 'Temporarily todo-ed for dq2eb';
-
 use lib qw(t/lib);
 use DBICTest;