From: Stevan Little <stevan.little@iinteractive.com>
Date: Thu, 10 Jan 2008 13:32:43 +0000 (+0000)
Subject: doc fixes, version updates and changelog
X-Git-Tag: 0_35~26
X-Git-Url: http://git.shadowcat.co.uk/gitweb/gitweb.cgi?a=commitdiff_plain;h=a4e516f663c16c559013862e7f51b0aec4fc3e5b;p=gitmo%2FMoose.git

doc fixes, version updates and changelog
---

diff --git a/Changes b/Changes
index 15defb4..eaeec07 100644
--- a/Changes
+++ b/Changes
@@ -10,6 +10,20 @@ Revision history for Perl extension Moose
         Thanks to Sartak for finding this ;)
         - added tests for this (Sartak again)
 
+    * Moose::Meta::Method::Accessor
+      Moose::Meta::Method::Constructor
+      Moose::Meta::Method::Attribute
+      - cleanup of some of the generated methods
+        (thanks to nothingmuch)
+
+    * Moose::Util::TypeConstraints
+      - all optimized type constraint subs are now 
+        pulled from the Moose::Util::TypeConstraints::OptimizedConstraints
+        module (thanks to nothingmuch)
+    
+    * Moose::Util::TypeConstraints::OptimizedConstraints
+      - added this module (see above)
+
 0.33 Fri. Dec. 14, 2007
     !! Moose now loads 2 x faster !!
     !!  with new Class::MOP 0.49  !!
diff --git a/lib/Moose.pm b/lib/Moose.pm
index 16e9b9f..85dc987 100644
--- a/lib/Moose.pm
+++ b/lib/Moose.pm
@@ -114,7 +114,7 @@ use Moose::Util::TypeConstraints;
                 }
                 else {
                     Moose::Meta::Role->combine(
-                        map { $_->[0]->meta } @$roles
+                        @$roles
                     )->apply($meta);
                 }
                 
@@ -552,7 +552,7 @@ quick example (soon to be expanded into a Moose::Cookbook::Recipe):
   has 'parent' => (
       is          => 'rw',
       isa         => 'Tree',
-      is_weak_ref => 1,
+      weak_ref => 1,
       handles     => {
           parent_node => 'node',
           siblings    => 'children',
diff --git a/lib/Moose/Cookbook/Recipe1.pod b/lib/Moose/Cookbook/Recipe1.pod
index 3413991..9797f56 100644
--- a/lib/Moose/Cookbook/Recipe1.pod
+++ b/lib/Moose/Cookbook/Recipe1.pod
@@ -119,7 +119,7 @@ a new attribute for B<Point3D> called C<z>.
 As with B<Point>'s C<x> and C<y> attributes, this attribute has a 
 type constraint of C<Int>, but it differs in that it does B<not> 
 ask for any autogenerated accessors. The result being (aside from 
-broken object encapsulation) that C<x> is a private attribute.
+broken object encapsulation) that C<z> is a private attribute.
 
 Next comes another Moose feature which we call method "modifiers" 
 (or method "advice" for the AOP inclined). The modifier used here 
diff --git a/lib/Moose/Meta/Attribute.pm b/lib/Moose/Meta/Attribute.pm
index 23324b2..104151d 100644
--- a/lib/Moose/Meta/Attribute.pm
+++ b/lib/Moose/Meta/Attribute.pm
@@ -9,7 +9,7 @@ use Carp         'confess';
 use Sub::Name    'subname';
 use overload     ();
 
-our $VERSION   = '0.16';
+our $VERSION   = '0.17';
 our $AUTHORITY = 'cpan:STEVAN';
 
 use Moose::Meta::Method::Accessor;
diff --git a/lib/Moose/Meta/Method/Accessor.pm b/lib/Moose/Meta/Method/Accessor.pm
index cc610cd..daf68b5 100644
--- a/lib/Moose/Meta/Method/Accessor.pm
+++ b/lib/Moose/Meta/Method/Accessor.pm
@@ -6,7 +6,7 @@ use warnings;
 
 use Carp 'confess';
 
-our $VERSION   = '0.09';
+our $VERSION   = '0.10';
 our $AUTHORITY = 'cpan:STEVAN';
 
 use base 'Moose::Meta::Method',
diff --git a/lib/Moose/Meta/Method/Constructor.pm b/lib/Moose/Meta/Method/Constructor.pm
index 9b1bb6d..0c0e1f6 100644
--- a/lib/Moose/Meta/Method/Constructor.pm
+++ b/lib/Moose/Meta/Method/Constructor.pm
@@ -7,7 +7,7 @@ use warnings;
 use Carp         'confess';
 use Scalar::Util 'blessed', 'weaken', 'looks_like_number';
 
-our $VERSION   = '0.03';
+our $VERSION   = '0.04';
 our $AUTHORITY = 'cpan:STEVAN';
 
 use base 'Moose::Meta::Method',
diff --git a/lib/Moose/Meta/Role.pm b/lib/Moose/Meta/Role.pm
index 34668f1..2039b12 100644
--- a/lib/Moose/Meta/Role.pm
+++ b/lib/Moose/Meta/Role.pm
@@ -375,13 +375,20 @@ sub apply {
 }
 
 sub combine {
-    my ($class, @roles) = @_;
+    my ($class, @role_specs) = @_;
     
     require Moose::Meta::Role::Application::RoleSummation;
-    require Moose::Meta::Role::Composite;    
+    require Moose::Meta::Role::Composite;  
+    
+    my @roles = map { $_->[0]->meta } @role_specs;
+    
+    my %params;
+    # how do I do this ...
     
     my $c = Moose::Meta::Role::Composite->new(roles => \@roles);
-    Moose::Meta::Role::Application::RoleSummation->new->apply($c);
+    Moose::Meta::Role::Application::RoleSummation->new(
+        %params
+    )->apply($c);
     return $c;
 }
 
diff --git a/lib/Moose/Role.pm b/lib/Moose/Role.pm
index 4be9f77..e4289ce 100644
--- a/lib/Moose/Role.pm
+++ b/lib/Moose/Role.pm
@@ -79,7 +79,7 @@ use Moose::Util::TypeConstraints;
                 }
                 else {
                     Moose::Meta::Role->combine(
-                        map { $_->[0]->meta } @$roles
+                        @$roles
                     )->apply($meta);
                 }
             };
diff --git a/lib/Moose/Util/TypeConstraints.pm b/lib/Moose/Util/TypeConstraints.pm
index e21179b..a040755 100644
--- a/lib/Moose/Util/TypeConstraints.pm
+++ b/lib/Moose/Util/TypeConstraints.pm
@@ -8,7 +8,7 @@ use Carp         'confess';
 use Scalar::Util 'blessed', 'reftype';
 use Sub::Exporter;
 
-our $VERSION   = '0.18';
+our $VERSION   = '0.19';
 our $AUTHORITY = 'cpan:STEVAN';
 
 ## --------------------------------------------------------