From: Peter Rabbitson Date: Fri, 31 Oct 2008 00:26:58 +0000 (+0000) Subject: It seems that some CPAN testers have a weird unreleased DBD::SQLite 1.14001 which... X-Git-Url: http://git.shadowcat.co.uk/gitweb/gitweb.cgi?a=commitdiff_plain;h=a4691709d18ace450500a9987f73e2a981df0a1c;p=dbsrgits%2FDBIx-Class-Historic.git It seems that some CPAN testers have a weird unreleased DBD::SQLite 1.14001 which return unexpected column info - fixing. Should take care of: http://www.nntp.perl.org/group/perl.cpan.testers/2008/10/msg2525124.html http://www.nntp.perl.org/group/perl.cpan.testers/2008/10/msg2525137.html --- diff --git a/t/64db.t b/t/64db.t index 3a761e4..40acdc1 100644 --- a/t/64db.t +++ b/t/64db.t @@ -38,9 +38,15 @@ my $type_info = $schema->storage->columns_info_for('artist'); # I know this is gross but SQLite reports the size differently from release # to release. At least this way the test still passes. - -delete $type_info->{$_}{size} for keys %$type_info; - +# Also it seems that some SQLite releases report stuff that isn't there as +# undef. So strip them out. +for my $col (keys %$type_info) { + for my $type (keys %{$type_info->{$col}}) { + if ($type eq 'size' or not defined $type_info->{$col}{$type} ) { + delete $type_info->{$col}{$type}; + } + } +} my $test_type_info = { 'artistid' => {