From: Peter Rabbitson Date: Sat, 30 May 2009 14:54:37 +0000 (+0000) Subject: TODOify some of the order with bind tests X-Git-Url: http://git.shadowcat.co.uk/gitweb/gitweb.cgi?a=commitdiff_plain;h=a2368d30d95457e6d4cc66cfb4603d32d41991d9;p=dbsrgits%2FDBIx-Class-Historic.git TODOify some of the order with bind tests --- diff --git a/t/order/with_bind.t b/t/order/with_bind.t index 109e24b..7a8bce6 100644 --- a/t/order/with_bind.t +++ b/t/order/with_bind.t @@ -2,6 +2,7 @@ use strict; use warnings; use Test::More; +use Test::Exception; use lib qw(t/lib); use DBICTest; use DBIC::SqlMakerTest; @@ -11,14 +12,14 @@ my $schema = DBICTest->init_schema; my $rs = $schema->resultset('FourKeys'); sub test_order { + + TODO: { my $args = shift; - my $req_order = - $args->{order_req} - ? "ORDER BY $args->{order_req}" - : ''; + local $TODO = "Not implemented" if $args->{todo}; - is_same_sql_bind( + lives_ok { + is_same_sql_bind( $rs->search( { foo => 'bar' }, { @@ -32,13 +33,20 @@ sub test_order { FROM fourkeys me WHERE ( foo = ? ) HAVING read_count > ? OR read_count < ? - $req_order + ORDER BY $args->{order_req} )", [ - [qw(foo bar)], [qw(read_count 5)], - 8, $args->{bind} ? @{ $args->{bind} } : () + [qw(foo bar)], + [qw(read_count 5)], + 8, + $args->{bind} + ? @{ $args->{bind} } + : () ], - ); + ); + }; + fail('Fail the unfinished is_same_sql_bind') if $@; + } } my @tests = ( @@ -71,7 +79,10 @@ my @tests = ( order_req => 'colA ASC, colB LIKE ? DESC, colC LIKE ? ASC', bind => [qw(test tost)], }, - { # this would be really really nice! + + # (mo) this would be really really nice! + # (ribasushi) I don't think so, not writing it - patches welcome + { order_by => [ { -asc => 'colA' }, { -desc => { colB => { 'LIKE' => 'test' } } }, @@ -79,15 +90,17 @@ my @tests = ( ], order_req => 'colA ASC, colB LIKE ? DESC, colC LIKE ? ASC', bind => [ [ colB => 'test' ], [ colC => 'tost' ] ], # ??? + todo => 1, }, { order_by => { -desc => { colA => { LIKE => 'test' } } }, order_req => 'colA LIKE ? DESC', bind => [qw(test)], + todo => 1, }, ); -plan( tests => scalar @tests ); +plan( tests => scalar @tests * 2 ); test_order($_) for @tests;