From: Peter Rabbitson Date: Mon, 17 Dec 2012 12:50:27 +0000 (+0100) Subject: Explicitly specify Scalar::Util dep, and work around RT#80646 on travis X-Git-Url: http://git.shadowcat.co.uk/gitweb/gitweb.cgi?a=commitdiff_plain;h=a08e7b00d0c4670291fdf7bc4e19438da3000723;p=dbsrgits%2FDBIx-Class-Historic.git Explicitly specify Scalar::Util dep, and work around RT#80646 on travis The inability to install Scalar::Util did not abort the cpan runs, and therefore revealed a nasty bug in first() that is present on all perl-bundled List::Utils until 5.8.8 --- diff --git a/Makefile.PL b/Makefile.PL index 8162234..b5c2368 100644 --- a/Makefile.PL +++ b/Makefile.PL @@ -47,6 +47,13 @@ my $runtime_requires = { # being 'DBI' => '1.57', + # on older versions first() leaks + # for the time being make it a hard dep - when we get + # rid of Sub::Name will revisit this (possibility is + # to use Devel::HideXS to force the pure-perl version + # or something like that) + 'List::Util' => '1.16', + # XS (or XS-dependent) libs 'Sub::Name' => '0.04', diff --git a/maint/travis-ci_prepare_env b/maint/travis-ci_prepare_env index 561790f..6e2b90e 100755 --- a/maint/travis-ci_prepare_env +++ b/maint/travis-ci_prepare_env @@ -301,6 +301,11 @@ if [[ "$CLEANTEST" = "true" ]]; then ##### TEMPORARY WORKAROUNDS + # List::Util got broken rather badly (RT#80646) + # install without tests for the time being + perl -M5.014 -e 1 &>/dev/null || \ + parallel_installdeps_notest List::Util + # not sure what's going on here yet perl -M5.008008 -e 1 &> /dev/null || \ parallel_installdeps_notest multidimensional bareword::filehandles