From: Peter Rabbitson <ribasushi@cpan.org>
Date: Sat, 24 Apr 2010 00:31:06 +0000 (+0000)
Subject: _quote is now properly handled in SQLA
X-Git-Url: http://git.shadowcat.co.uk/gitweb/gitweb.cgi?a=commitdiff_plain;h=a07bb26c5bd12b153223d88d76e018b6690df785;p=dbsrgits%2FDBIx-Class-Historic.git

_quote is now properly handled in SQLA
---

diff --git a/Changes b/Changes
index 185677f..0ca073b 100644
--- a/Changes
+++ b/Changes
@@ -2,12 +2,13 @@ Revision history for DBIx::Class
 
         - Add a warning to load_namespaces if a class in ResultSet/ is not a subclass of DBIx::Class::ResultSet
         - InflateColumn::DateTime support for MSSQL via DBD::Sybase
-        - millisecond precision support for MSSQL datetimes for
+        - Millisecond precision support for MSSQL datetimes for
           InflateColumn::DateTime
-        - support connecting using $ENV{DBI_DSN} and $ENV{DBI_DRIVER}
+        - Support connecting using $ENV{DBI_DSN} and $ENV{DBI_DRIVER}
         - current_source_alias method on ResultSet objects to
           determine the alias to use in programatically assembled
           search()es (originally added in 0.08100 but unmentioned)
+        - Depend on optimized SQL::Abstract (faster SQL generation)
 
 0.08121 2010-04-11 18:43:00 (UTC)
         - Support for Firebird RDBMS with DBD::InterBase and ODBC
diff --git a/Makefile.PL b/Makefile.PL
index f5962a0..e92cdb8 100644
--- a/Makefile.PL
+++ b/Makefile.PL
@@ -45,7 +45,7 @@ my $runtime_requires = {
   'MRO::Compat'              => '0.09',
   'Module::Find'             => '0.06',
   'Path::Class'              => '0.18',
-  'SQL::Abstract'            => '1.64',
+  'SQL::Abstract'            => '1.65_02',
   'SQL::Abstract::Limit'     => '0.13',
   'Sub::Name'                => '0.04',
   'Data::Dumper::Concise'    => '1.000',
diff --git a/lib/DBIx/Class/SQLAHacks.pm b/lib/DBIx/Class/SQLAHacks.pm
index 4da469e..172136b 100644
--- a/lib/DBIx/Class/SQLAHacks.pm
+++ b/lib/DBIx/Class/SQLAHacks.pm
@@ -596,23 +596,6 @@ sub _join_condition {
   }
 }
 
-sub _quote {
-  my ($self, $label) = @_;
-  return '' unless defined $label;
-  return $$label if ref($label) eq 'SCALAR';
-  return "*" if $label eq '*';
-  return $label unless $self->{quote_char};
-  if(ref $self->{quote_char} eq "ARRAY"){
-    return $self->{quote_char}->[0] . $label . $self->{quote_char}->[1]
-      if !defined $self->{name_sep};
-    my $sep = $self->{name_sep};
-    return join($self->{name_sep},
-        map { $self->{quote_char}->[0] . $_ . $self->{quote_char}->[1]  }
-       split(/\Q$sep\E/,$label));
-  }
-  return $self->SUPER::_quote($label);
-}
-
 sub limit_dialect {
     my $self = shift;
     $self->{limit_dialect} = shift if @_;