From: Peter Rabbitson Date: Tue, 29 Jul 2014 09:01:11 +0000 (+0200) Subject: Remove unused leftover from c19ca6e80 - there was much flailing :( X-Git-Url: http://git.shadowcat.co.uk/gitweb/gitweb.cgi?a=commitdiff_plain;h=9fcb1c744e968f1d24a4fc3365b8f3929a89b970;p=dbsrgits%2FDBIx-Class-Historic.git Remove unused leftover from c19ca6e80 - there was much flailing :( --- diff --git a/lib/DBIx/Class/ResultSource.pm b/lib/DBIx/Class/ResultSource.pm index 7d172bd..ce048b9 100644 --- a/lib/DBIx/Class/ResultSource.pm +++ b/lib/DBIx/Class/ResultSource.pm @@ -2116,8 +2116,8 @@ sub _resolve_relationship_condition { next if $col_eqs->{$lhs} eq UNRESOLVABLE_CONDITION; my ($rhs) = @{ is_literal_value( $ret->{condition}{$lhs} ) || next }; - # there is no way to know who is right and who is left - # therefore the ugly scan below + # there is no way to know who is right and who is left in a cref + # therefore a full blown resolution call # TEMP my $rel_rsrc = $self->related_source($args->{rel_name}); $colinfos ||= $storage->_resolve_column_info([ @@ -2125,9 +2125,7 @@ sub _resolve_relationship_condition { { -alias => $args->{foreign_alias}, -rsrc => $rel_rsrc }, ]); - my ($l_col, $l_alias, $r_col, $r_alias) = map { - ( reverse $_ =~ / ^ (?: ([^\.]+) $ | ([^\.]+) \. (.+) ) /x )[0,1] - } ($lhs, $rhs); + my ($l_col, $r_col) = map { $_ =~ / ([^\.]+) $ /x } ($lhs, $rhs); if ( $colinfos->{$l_col}