From: Nicholas Clark Date: Mon, 23 Jan 2006 19:06:41 +0000 (+0000) Subject: constant_add_symbol needs to be static, else static builds can fail at X-Git-Url: http://git.shadowcat.co.uk/gitweb/gitweb.cgi?a=commitdiff_plain;h=9fb4165716e9d7e90180e75d92d68781f04d8ad0;p=p5sagit%2Fp5-mst-13.2.git constant_add_symbol needs to be static, else static builds can fail at link time. (*How* many meanings is "static" overloaded with?) p4raw-id: //depot/perl@26932 --- diff --git a/lib/ExtUtils/Constant/ProxySubs.pm b/lib/ExtUtils/Constant/ProxySubs.pm index 2df31b9..d9c9ac3 100644 --- a/lib/ExtUtils/Constant/ProxySubs.pm +++ b/lib/ExtUtils/Constant/ProxySubs.pm @@ -198,7 +198,8 @@ sub WriteConstants { my $symbol_table = C_stringify($package) . '::'; print $c_fh $self->header(), <<"EOADD"; -void ${c_subname}_add_symbol($pthx HV *hash, const char *name, I32 namelen, SV *value) { +static void +${c_subname}_add_symbol($pthx HV *hash, const char *name, I32 namelen, SV *value) { SV **sv = hv_fetch(hash, name, namelen, TRUE); if (!sv) { Perl_croak($athx "Couldn't add key '%s' to %%$package_sprintf_safe\::",