From: Peter Rabbitson Date: Sat, 15 Dec 2012 08:29:18 +0000 (+0100) Subject: I was wrong about 2d12a809 - the crash is real X-Git-Url: http://git.shadowcat.co.uk/gitweb/gitweb.cgi?a=commitdiff_plain;h=9dfb034ff8191ec4648a65ac99dd5e281c7040c3;p=dbsrgits%2FDBIx-Class-Historic.git I was wrong about 2d12a809 - the crash is real Switch remaining problematic tests to skip away in is_plain (enduser installation) mode, keep failing for the time being for authors until a cause is found. Please *DO NOT* quietly skip inconvenient tests --- diff --git a/t/51threadnodb.t b/t/51threadnodb.t index 52cdcd8..9b69fa1 100644 --- a/t/51threadnodb.t +++ b/t/51threadnodb.t @@ -11,11 +11,14 @@ use strict; use warnings; use Test::More; +use lib qw(t/lib); +use DBICTest; + plan skip_all => 'DBIC does not actively support threads before perl 5.8.5' if $] < '5.008005'; -use lib qw(t/lib); -use DBICTest; +plan skip_all => 'Potential problems on Win32 Perl < 5.14 and Variable::Magic - investigation pending' + if $^O eq 'MSWin32' && $] < 5.014 && DBICTest::RunMode->is_plain; # README: If you set the env var to a number greater than 10, # we will use that many children diff --git a/t/storage/global_destruction.t b/t/storage/global_destruction.t index e75e277..8b22c8d 100644 --- a/t/storage/global_destruction.t +++ b/t/storage/global_destruction.t @@ -9,7 +9,8 @@ use DBIx::Class::Optional::Dependencies (); use lib qw(t/lib); use DBICTest; -plan skip_all => 'Test segfaults on Win32' if $^O eq 'MSWin32'; +plan skip_all => 'Test segfaults on Win32 - investigation pending' + if $^O eq 'MSWin32' && DBICTest::RunMode->is_plain; for my $type (qw/PG MYSQL SQLite/) {