From: Stevan Little <stevan.little@iinteractive.com>
Date: Sat, 31 Mar 2007 17:51:06 +0000 (+0000)
Subject: more tests
X-Git-Tag: 0_02~24
X-Git-Url: http://git.shadowcat.co.uk/gitweb/gitweb.cgi?a=commitdiff_plain;h=95f31c36141c0108605fadf16d9abd9ec8bd63f3;p=gitmo%2FMooseX-Storage.git

more tests
---

diff --git a/lib/MooseX/Storage/Engine.pm b/lib/MooseX/Storage/Engine.pm
index 4fd3108..cae2407 100644
--- a/lib/MooseX/Storage/Engine.pm
+++ b/lib/MooseX/Storage/Engine.pm
@@ -150,7 +150,7 @@ my %TYPES = (
             # otherwise it will affect the 
             # other real version.
             +{ map {
-                blessed($_)
+                blessed($hash->{$_})
                     ? ($_ => $OBJECT_HANDLERS{collapse}->($hash->{$_}))
                     : ($_ => $hash->{$_})
             } keys %$hash }            
diff --git a/t/002_basic_w_subtypes.t b/t/002_basic_w_subtypes.t
index 3806d02..663dda4 100644
--- a/t/002_basic_w_subtypes.t
+++ b/t/002_basic_w_subtypes.t
@@ -9,6 +9,14 @@ BEGIN {
     use_ok('MooseX::Storage');
 }
 
+=pod
+
+This extends the 001_basic test to 
+show that subtypes will DWIM in most 
+cases.
+
+=cut
+
 {
 
     package Foo;
diff --git a/t/003_basic_w_embedded_objects.t b/t/003_basic_w_embedded_objects.t
index de33dff..ecb0b76 100644
--- a/t/003_basic_w_embedded_objects.t
+++ b/t/003_basic_w_embedded_objects.t
@@ -9,6 +9,14 @@ BEGIN {
     use_ok('MooseX::Storage');
 }
 
+=pod
+
+This test checks the single level 
+expansion and collpasing of the 
+ArrayRef and HashRef type handlers.
+
+=cut
+
 {
     package Bar;
     use Moose;
@@ -16,7 +24,7 @@ BEGIN {
 
     with Storage;
     
-    has 'baz' => (is => 'ro', isa => 'Int');
+    has 'number' => (is => 'ro', isa => 'Int');
     
     package Foo;
     use Moose;
@@ -28,11 +36,22 @@ BEGIN {
         is  => 'ro', 
         isa => 'ArrayRef' 
     );
+    
+    package Baz;
+    use Moose;
+    use MooseX::Storage;
+
+    with Storage;    
+
+    has 'bars' => ( 
+        is  => 'ro', 
+        isa => 'HashRef' 
+    );    
 }
 
 {
     my $foo = Foo->new(
-        bars => [ map { Bar->new(baz => $_) } (1 .. 10) ]
+        bars => [ map { Bar->new(number => $_) } (1 .. 10) ]
     );
     isa_ok( $foo, 'Foo' );
     
@@ -44,7 +63,7 @@ BEGIN {
                 map {
                   {
                       __class__ => 'Bar',
-                      baz       => $_,
+                      number    => $_,
                   }  
                 } (1 .. 10)
             ],           
@@ -61,7 +80,7 @@ BEGIN {
                 map {
                   {
                       __class__ => 'Bar',
-                      baz       => $_,
+                      number    => $_,
                   }  
                 } (1 .. 10)
             ],           
@@ -71,6 +90,52 @@ BEGIN {
 
     foreach my $i (1 .. scalar @{$foo->bars}) {
         isa_ok($foo->bars->[$i - 1], 'Bar');
-        is($foo->bars->[$i - 1]->baz, $i, "... got the right baz ($i) in the Bar in Foo");
+        is($foo->bars->[$i - 1]->number, $i, "... got the right number ($i) in the Bar in Foo");
+    }
+}
+
+
+{
+    my $baz = Baz->new(
+        bars => { map { ($_ => Bar->new(number => $_)) } (1 .. 10) }
+    );
+    isa_ok( $baz, 'Baz' );
+    
+    is_deeply(
+        $baz->pack,
+        {
+            __class__ => 'Baz',
+            bars      => {
+                map {
+                  ($_ => {
+                      __class__ => 'Bar',
+                      number    => $_,
+                  })  
+                } (1 .. 10)
+            },           
+        },
+        '... got the right frozen class'
+    );
+}
+
+{
+    my $baz = Baz->unpack(
+        {
+            __class__ => 'Baz',
+            bars      => {
+                map {
+                  ($_ => {
+                      __class__ => 'Bar',
+                      number    => $_,
+                  })  
+                } (1 .. 10)
+            },           
+        }      
+    );
+    isa_ok( $baz, 'Baz' );
+
+    foreach my $k (keys %{$baz->bars}) {
+        isa_ok($baz->bars->{$k}, 'Bar');
+        is($baz->bars->{$k}->number, $k, "... got the right number ($k) in the Bar in Baz");
     }
 }