From: Peter Rabbitson Date: Sun, 14 Nov 2010 12:23:19 +0000 (+0100) Subject: Unqualify imported functions X-Git-Url: http://git.shadowcat.co.uk/gitweb/gitweb.cgi?a=commitdiff_plain;h=94244987e66865e4c0c37385248176330ae69029;p=dbsrgits%2FDBIx-Class-Historic.git Unqualify imported functions --- diff --git a/lib/DBIx/Class/ResultSet.pm b/lib/DBIx/Class/ResultSet.pm index 0a6963b..b0a1550 100644 --- a/lib/DBIx/Class/ResultSet.pm +++ b/lib/DBIx/Class/ResultSet.pm @@ -9,13 +9,17 @@ use Data::Page; use Storable; use DBIx::Class::ResultSetColumn; use DBIx::Class::ResultSourceHandle; -use List::Util (); use Hash::Merge (); use Scalar::Util qw/blessed weaken/; use Try::Tiny; use Storable qw/nfreeze thaw/; + +# not importing first() as it will clash with our own method +use List::Util (); + use namespace::clean; + BEGIN { # De-duplication in _merge_attr() is disabled, but left in for reference *__HM_DEDUP = sub () { 0 }; diff --git a/lib/DBIx/Class/ResultSetColumn.pm b/lib/DBIx/Class/ResultSetColumn.pm index 12623a3..a459bc3 100644 --- a/lib/DBIx/Class/ResultSetColumn.pm +++ b/lib/DBIx/Class/ResultSetColumn.pm @@ -7,6 +7,8 @@ use base 'DBIx::Class'; use Carp::Clan qw/^DBIx::Class/; use DBIx::Class::Exception; + +# not importing first() as it will clash with our own method use List::Util (); =head1 NAME diff --git a/lib/DBIx/Class/Storage/DBI.pm b/lib/DBIx/Class/Storage/DBI.pm index ed2ab1b..c512334 100644 --- a/lib/DBIx/Class/Storage/DBI.pm +++ b/lib/DBIx/Class/Storage/DBI.pm @@ -171,9 +171,9 @@ sub new { sub _arm_global_destructor { my $self = shift; - my $key = Scalar::Util::refaddr ($self); + my $key = refaddr ($self); $seek_and_destroy{$key} = $self; - Scalar::Util::weaken ($seek_and_destroy{$key}); + weaken ($seek_and_destroy{$key}); } END {