From: Matt S Trout Date: Fri, 11 Sep 2009 00:33:17 +0000 (+0000) Subject: make it clear that we are not supposed to have optional deps X-Git-Url: http://git.shadowcat.co.uk/gitweb/gitweb.cgi?a=commitdiff_plain;h=93c508897a53337dd5f860a92fb142fd0aede2de;p=dbsrgits%2FDBIx-Class-Historic.git make it clear that we are not supposed to have optional deps --- diff --git a/Changes b/Changes index efbb38c..f64e3bd 100644 --- a/Changes +++ b/Changes @@ -1,5 +1,9 @@ Revision history for DBIx::Class + - remove the recommends from Makefile.PL, DBIx::Class is not + supposed to have optional dependencies. ever. + - mangle the DBIx/Class.pm POD to be more clear about + copyright and license - Change ResultSetColumn->reset() to no longer return $self, which fixes an issue with using Cursor::Cached and ResultSetColumn together. diff --git a/Makefile.PL b/Makefile.PL index adbd004..de16db0 100644 --- a/Makefile.PL +++ b/Makefile.PL @@ -5,6 +5,8 @@ use POSIX (); use 5.006001; # delete this line if you want to send patches for earlier. +# ****** DO NOT ADD OPTIONAL DEPENDENCIES. EVER. --mst ****** + name 'DBIx-Class'; perl_version '5.006001'; all_from 'lib/DBIx/Class.pm'; @@ -52,11 +54,6 @@ my %replication_requires = ( 'Hash::Merge', => '0.11', ); -# when changing also adjust $DBIx::Class::minimum_sqlt_version -my $sqlt_recommends = '0.11002'; - -recommends 'SQL::Translator' => $sqlt_recommends; - my %force_requires_if_author = ( %replication_requires,