From: Matt S Trout Date: Tue, 21 Aug 2007 19:17:22 +0000 (+0000) Subject: oracle datetime inflator patch X-Git-Url: http://git.shadowcat.co.uk/gitweb/gitweb.cgi?a=commitdiff_plain;h=8f7e044cb8cdcb2c644e53b86e3a520754ae790e;p=dbsrgits%2FDBIx-Class-Historic.git oracle datetime inflator patch --- diff --git a/Changes b/Changes index a7c93bd..bf8a7ff 100644 --- a/Changes +++ b/Changes @@ -1,5 +1,6 @@ Revision history for DBIx::Class + - patch for Oracle datetime inflation (abram@arin.net) - added on_disconnect_do - on_connect_do and on_disconnect_do take coderefs and arrayrefs diff --git a/lib/DBIx/Class/Storage/DBI/Oracle/Generic.pm b/lib/DBIx/Class/Storage/DBI/Oracle/Generic.pm index eeade7f..12f1dcb 100644 --- a/lib/DBIx/Class/Storage/DBI/Oracle/Generic.pm +++ b/lib/DBIx/Class/Storage/DBI/Oracle/Generic.pm @@ -84,6 +84,15 @@ sub columns_info_for { $self->next::method(uc($table)); } +=head2 datetime_parser_type + +This sets the proper DateTime::Format module for use with +L. + +=cut + +sub datetime_parser_type { return "DateTime::Format::Oracle"; } + =head1 AUTHORS Andy Grundman diff --git a/t/73oracle_inflate.t b/t/73oracle_inflate.t new file mode 100644 index 0000000..76085e6 --- /dev/null +++ b/t/73oracle_inflate.t @@ -0,0 +1,64 @@ +use strict; +use warnings; + +use Test::More; +use lib qw(t/lib); +use DBICTest; + +my ($dsn, $user, $pass) = @ENV{map { "DBICTEST_ORA_${_}" } qw/DSN USER PASS/}; + +eval "use DateTime; use DateTime::Format::Oracle;"; +if ($@) { + plan skip_all => 'needs DateTime and DateTime::Format::Oracle for testing'; +} +elsif (not ($dsn && $user && $pass)) { + plan skip_all => 'Set $ENV{DBICTEST_ORA_DSN}, _USER and _PASS to run this test. ' . + 'Warning: This test drops and creates a table called \'track\''; +} +else { + plan tests => 4; +} + +# DateTime::Format::Oracle needs this set +$ENV{NLS_DATE_FORMAT} = 'DD-MON-YY'; + +my $schema = DBICTest::Schema->connect($dsn, $user, $pass); + +# Need to redefine the last_updated_on column +my $col_metadata = $schema->class('Track')->column_info('last_updated_on'); +$schema->class('Track')->add_column( 'last_updated_on' => { + data_type => 'date' }); + +my $dbh = $schema->storage->dbh; + +eval { + $dbh->do("DROP TABLE track"); +}; +$dbh->do("CREATE TABLE track (trackid NUMBER(12), cd NUMBER(12), position NUMBER(12), title VARCHAR(255), last_updated_on DATE)"); + +# insert a row to play with +my $new = $schema->resultset('Track')->create({ trackid => 1, cd => 1, position => 1, title => 'Track1', last_updated_on => '06-MAY-07' }); +is($new->trackid, 1, "insert sucessful"); + +my $track = $schema->resultset('Track')->find( 1 ); + +is( ref($track->last_updated_on), 'DateTime', "last_updated_on inflated ok"); + +is( $track->last_updated_on->month, 5, "DateTime methods work on inflated column"); + +my $dt = DateTime->now(); +$track->last_updated_on($dt); +$track->update; + +is( $track->last_updated_on->month, $dt->month, "deflate ok"); + +# clean up our mess +END { + # Set the metadata back for the last_updated_on column + $schema->class('Track')->add_column( 'last_updated_on' => $col_metadata ); + + if($dbh) { + $dbh->do("DROP TABLE track"); + } +} +