From: David Dyck <david.dyck@fluke.com>
Date: Wed, 8 Nov 2000 18:36:26 +0000 (-0800)
Subject: patch to detect stat followed by lstat(_): [ID 20001106.006] find2perl generated... 
X-Git-Url: http://git.shadowcat.co.uk/gitweb/gitweb.cgi?a=commitdiff_plain;h=8a4e5b40dba3387613897ea9c275824694f125bc;p=p5sagit%2Fp5-mst-13.2.git

patch to detect stat followed by lstat(_): [ID 20001106.006] find2perl generated scripts issue new lstat()    on filehandle _ warning
Message-ID: <Pine.LNX.4.30.0011081817490.177-100000@dd.tc.fluke.com>

p4raw-id: //depot/perl@7620
---

diff --git a/pp_sys.c b/pp_sys.c
index 7a9dc39..4b8bfce 100644
--- a/pp_sys.c
+++ b/pp_sys.c
@@ -2557,9 +2557,15 @@ PP(pp_stat)
 
     if (PL_op->op_flags & OPf_REF) {
 	gv = cGVOP_gv;
-	if (PL_op->op_type == OP_LSTAT && ckWARN(WARN_IO) && gv != PL_defgv)
-	    Perl_warner(aTHX_ WARN_IO,
+	if (PL_op->op_type == OP_LSTAT) {
+	    if (PL_laststype != OP_LSTAT)
+		Perl_croak(aTHX_ "The stat preceding lstat() wasn't an lstat");
+	    if (ckWARN(WARN_IO) && gv != PL_defgv)
+		Perl_warner(aTHX_ WARN_IO,
 			"lstat() on filehandle %s", GvENAME(gv));
+		/* Perl_my_lstat (-l) croak's on filehandle, why warn here? */
+	}
+
       do_fstat:
 	if (gv != PL_defgv) {
 	    PL_laststype = OP_STAT;