From: Norbert Buchmuller Date: Tue, 25 Nov 2008 04:38:08 +0000 (+0100) Subject: * Fixed the test plan in 72pg.t. X-Git-Url: http://git.shadowcat.co.uk/gitweb/gitweb.cgi?a=commitdiff_plain;h=89869c75ac532068518bfc72e33468014bb68e43;p=dbsrgits%2FDBIx-Class-Historic.git * Fixed the test plan in 72pg.t. * Fixed SQLA version check in SKIP tests (it's 1.49 in current 1.50RC branch). --- diff --git a/t/72pg.t b/t/72pg.t index 4c7721f..951be49 100644 --- a/t/72pg.t +++ b/t/72pg.t @@ -47,7 +47,7 @@ plan skip_all => 'Set $ENV{DBICTEST_PG_DSN}, _USER and _PASS to run this test '. unless ($dsn && $user && $pass); -plan tests => 36; +plan tests => 37; DBICTest::Schema->load_classes( 'Casecheck', 'ArrayTest' ); my $schema = DBICTest::Schema->connect($dsn, $user, $pass); @@ -133,8 +133,8 @@ is_deeply($type_info, $test_type_info, 'columns_info_for - column data types'); SKIP: { - skip "SQL::Abstract < 1.50 does not pass through arrayrefs", 3 - if $SQL::Abstract::VERSION < 1.50; + skip "SQL::Abstract < 1.49 does not pass through arrayrefs", 3 + if $SQL::Abstract::VERSION < 1.49; lives_ok { $schema->resultset('ArrayTest')->create({ diff --git a/t/95sql_maker.t b/t/95sql_maker.t index 900e604..ee6ccdd 100644 --- a/t/95sql_maker.t +++ b/t/95sql_maker.t @@ -22,7 +22,8 @@ my $sql_maker = $schema->storage->sql_maker; SKIP: { - skip "SQL::Abstract < 1.50 does not pass through arrayrefs", 2 if $SQL::Abstract::VERSION < 1.50; + skip "SQL::Abstract < 1.49 does not pass through arrayrefs", 2 + if $SQL::Abstract::VERSION < 1.49; my ($sql, @bind) = $sql_maker->insert( 'lottery', diff --git a/t/95sql_maker_quote.t b/t/95sql_maker_quote.t index 5fef846..162c59f 100644 --- a/t/95sql_maker_quote.t +++ b/t/95sql_maker_quote.t @@ -112,7 +112,8 @@ is_same_sql_bind( ); SKIP: { - skip "SQL::Abstract < 1.50 does not support hashrefs in order_by", 2 if $SQL::Abstract::VERSION < 1.50; + skip "SQL::Abstract < 1.49 does not support hashrefs in order_by", 2 + if $SQL::Abstract::VERSION < 1.49; ($sql, @bind) = $sql_maker->select( [