From: Peter Rabbitson <ribasushi@cpan.org>
Date: Thu, 4 Feb 2016 08:54:13 +0000 (+0100)
Subject: Remove statement cache eviction before disconnect
X-Git-Url: http://git.shadowcat.co.uk/gitweb/gitweb.cgi?a=commitdiff_plain;h=88c5ab3ffb9b6ca4f675ae5155d356fbe53c70a8;p=dbsrgits%2FDBIx-Class-Historic.git

Remove statement cache eviction before disconnect

This was added for no apparent reason with a ton of other code in f200d74b.
It is known to have unintended effects on at least ::Pg handles (as detailed
in theory/dbix-connector/issues/39) and generally seems like a gratuitous
action to take.

Given it doesn't seem to add extra noise on any of the test runs - kill it
with fire.
---

diff --git a/lib/DBIx/Class/Storage/DBI.pm b/lib/DBIx/Class/Storage/DBI.pm
index ac6489d..1c2a922 100644
--- a/lib/DBIx/Class/Storage/DBI.pm
+++ b/lib/DBIx/Class/Storage/DBI.pm
@@ -905,8 +905,6 @@ sub disconnect {
     # stops the "implicit rollback on disconnect" warning
     $self->_exec_txn_rollback unless $self->_dbh_autocommit;
 
-    %{ $dbh->{CachedKids} } = ();
-
     $dbh->disconnect;
   }
 }