From: Nicholas Clark <nick@ccl4.org>
Date: Tue, 3 May 2005 12:00:25 +0000 (+0000)
Subject: ok($a == $b) better written as cmp_ok($a, '==', $b)
X-Git-Url: http://git.shadowcat.co.uk/gitweb/gitweb.cgi?a=commitdiff_plain;h=87f4a7b253858acc72094bac97b22c3f9126c030;p=p5sagit%2Fp5-mst-13.2.git

ok($a == $b) better written as cmp_ok($a, '==', $b)
(The latter gives more diagnostics in the case of failure)

p4raw-id: //depot/perl@24377
---

diff --git a/t/op/exp.t b/t/op/exp.t
index 927c5da..707deb9 100755
--- a/t/op/exp.t
+++ b/t/op/exp.t
@@ -16,7 +16,7 @@ is(substr($s,0,5), '1.414');
 $s = exp(1);
 is(substr($s,0,7), '2.71828');
 
-ok(exp(log(1)) == 1);
+cmp_ok(exp(log(1)), '==', 1);
 
 # run time evaluation
 
@@ -28,7 +28,7 @@ is(substr($s,0,5), '1.414');
 $s = exp($x1);
 is(substr($s,0,7), '2.71828');
 
-ok(exp(log($x1)) == 1);
+cmp_ok(exp(log($x1)), '==', 1);
 
 # tests for transcendental functions
 
@@ -41,23 +41,23 @@ sub round {
 }
 
 # sin() tests
-ok(sin(0) == 0.0);
-ok(round(sin($pi)) == 0.0);
-ok(round(sin(-1 * $pi)) == 0.0);
-ok(round(sin($pi_2)) == 1.0);
-ok(round(sin(-1 * $pi_2)) == -1.0);
+cmp_ok(sin(0), '==', 0.0);
+cmp_ok(round(sin($pi)), '==', 0.0);
+cmp_ok(round(sin(-1 * $pi)), '==', 0.0);
+cmp_ok(round(sin($pi_2)), '==', 1.0);
+cmp_ok(round(sin(-1 * $pi_2)), '==', -1.0);
 
 # cos() tests
-ok(cos(0) == 1.0);
-ok(round(cos($pi)) == -1.0);
-ok(round(cos(-1 * $pi)) == -1.0);
-ok(round(cos($pi_2)) == 0.0);
-ok(round(cos(-1 * $pi_2)) == 0.0);
+cmp_ok(cos(0), '==', 1.0);
+cmp_ok(round(cos($pi)), '==', -1.0);
+cmp_ok(round(cos(-1 * $pi)), '==', -1.0);
+cmp_ok(round(cos($pi_2)), '==', 0.0);
+cmp_ok(round(cos(-1 * $pi_2)), '==', 0.0);
 
 # atan2() tests
-ok(round(atan2(-0.0, 0.0)) == 0);
-ok(round(atan2(0.0, 0.0)) == 0);
-ok(round(atan2(-0.0, -0.0)) == round(-1 * $pi));
-ok(round(atan2(0.0, -0.0)) == round($pi));
-ok(round(atan2(-1.0, 0.0)) == round(-1 * $pi_2));
-ok(round(atan2(1.0, 0.0)) == round($pi_2));
+cmp_ok(round(atan2(-0.0, 0.0)), '==', 0);
+cmp_ok(round(atan2(0.0, 0.0)), '==', 0);
+cmp_ok(round(atan2(-0.0, -0.0)), '==', round(-1 * $pi));
+cmp_ok(round(atan2(0.0, -0.0)), '==', round($pi));
+cmp_ok(round(atan2(-1.0, 0.0)), '==', round(-1 * $pi_2));
+cmp_ok(round(atan2(1.0, 0.0)), '==', round($pi_2));