From: Nicholas Clark Date: Thu, 10 Jan 2008 22:06:53 +0000 (+0000) Subject: It seems that you don't need to reference count PL_reg_curpm without X-Git-Url: http://git.shadowcat.co.uk/gitweb/gitweb.cgi?a=commitdiff_plain;h=86c29d75e7a3f6437747e5739890c22532d1c305;p=p5sagit%2Fp5-mst-13.2.git It seems that you don't need to reference count PL_reg_curpm without ithreads, so don't waste time doing it there. p4raw-id: //depot/perl@32939 --- diff --git a/regexec.c b/regexec.c index 5ce1ee3..3a7d461 100644 --- a/regexec.c +++ b/regexec.c @@ -2264,10 +2264,15 @@ S_regtry(pTHX_ regmatch_info *reginfo, char **startpos) } #endif } +#ifdef USE_ITHREADS + /* It seems that non-ithreads works both with and without this code. + So for efficiency reasons it seems best not to have the code + compiled when it is not needed. */ /* This is safe against NULLs: */ ReREFCNT_dec(PM_GETRE(PL_reg_curpm)); /* PM_reg_curpm owns a reference to this regexp. */ ReREFCNT_inc(rx); +#endif PM_SETRE(PL_reg_curpm, rx); PL_reg_oldcurpm = PL_curpm; PL_curpm = PL_reg_curpm;