From: Peter Rabbitson Date: Tue, 10 Feb 2009 11:19:20 +0000 (+0000) Subject: More rh-bug related stuff: X-Git-Url: http://git.shadowcat.co.uk/gitweb/gitweb.cgi?a=commitdiff_plain;h=8622bf34344c2872e8dae06417b1758fe2ed41a0;p=dbsrgits%2FDBIx-Class-Historic.git More rh-bug related stuff: - Improve message emmitted when confronted with a buggy system - Port forgotten pieces from trunk to stopgap --- diff --git a/t/99rh_perl_perf_bug.t b/t/99rh_perl_perf_bug.t index 4b275fb..8bed2d7 100644 --- a/t/99rh_perl_perf_bug.t +++ b/t/99rh_perl_perf_bug.t @@ -61,11 +61,15 @@ my $ratio = $results->{no_bless}->iters / $results->{bless_overload}->iters; ok( ( $ratio < 2 ), 'Overload/bless performance acceptable' ) || diag( + "\n", "This perl has a substantial slow down when handling large numbers\n", "of blessed/overloaded objects. This can severely adversely affect\n", "the performance of DBIx::Class programs. Please read the section\n", "in the Troubleshooting POD documentation entitled\n", "'Perl Performance Issues on Red Hat Systems'\n", + "As this is an extremely serious condition, the only way to skip\n", + "over this test is to --force the installation, or to edit the test\n", + "file " . __FILE__ . "\n", ); # We will only check for the difference in bless handling (whether the @@ -106,8 +110,12 @@ SKIP: { ok( !_possibly_has_bad_overload_performance(), 'Checking whether bless applies to reference not object' ) || diag( + "\n", "This perl is probably derived from a buggy Red Hat perl build\n", "Please read the section in the Troubleshooting POD documentation\n", "entitled 'Perl Performance Issues on Red Hat Systems'\n", + "As this is an extremely serious condition, the only way to skip\n", + "over this test is to --force the installation, or to edit the test\n", + "file " . __FILE__ . "\n", ); }