From: Dave Rolsky Date: Thu, 23 Oct 2008 16:16:52 +0000 (+0000) Subject: s/childtype/child_type/g - why ignore every naming standard already in use in the... X-Git-Tag: 0.60~16 X-Git-Url: http://git.shadowcat.co.uk/gitweb/gitweb.cgi?a=commitdiff_plain;h=85a9908f23fbb88856149822236cf6844641c699;p=gitmo%2FMoose.git s/childtype/child_type/g - why ignore every naming standard already in use in the codebase, I ask rhetorically --- diff --git a/lib/Moose/Meta/TypeConstraint.pm b/lib/Moose/Meta/TypeConstraint.pm index 05a3f44..c301eba 100644 --- a/lib/Moose/Meta/TypeConstraint.pm +++ b/lib/Moose/Meta/TypeConstraint.pm @@ -246,7 +246,7 @@ sub _collect_all_parents { return @parents; } -sub create_childtype { +sub create_child_type { my ($self, %opts) = @_; my $class = ref $self; return $class->new(%opts, parent => $self); @@ -353,7 +353,7 @@ Returns true if this type has a parent type. =item B -=item B +=item B =back diff --git a/lib/Moose/Meta/TypeConstraint/Parameterized.pm b/lib/Moose/Meta/TypeConstraint/Parameterized.pm index 668a9db..9300d7a 100644 --- a/lib/Moose/Meta/TypeConstraint/Parameterized.pm +++ b/lib/Moose/Meta/TypeConstraint/Parameterized.pm @@ -56,7 +56,7 @@ sub compile_type_constraint { . $self->parent->name . " doesn't subtype or coerce from a parameterizable type."); } -sub create_childtype { +sub create_child_type { my ($self, %opts) = @_; return Moose::Meta::TypeConstraint->new(%opts, parent => $self); } @@ -86,7 +86,7 @@ Moose::Meta::TypeConstraint::Parameterized - Higher Order type constraints for M =item B -=item B +=item B =back diff --git a/lib/Moose/Meta/TypeConstraint/Union.pm b/lib/Moose/Meta/TypeConstraint/Union.pm index c9d3f42..a96a576 100644 --- a/lib/Moose/Meta/TypeConstraint/Union.pm +++ b/lib/Moose/Meta/TypeConstraint/Union.pm @@ -100,7 +100,7 @@ sub is_subtype_of { return 0; } -sub create_childtype { +sub create_child_type { my ($self, %opts) = @_; my $class = ref $self; my $constraint = Moose::Meta::TypeConstraint->new(%opts, parent => $self); @@ -204,7 +204,7 @@ anyway. They are here for completeness. =item B -=item B +=item B =back diff --git a/lib/Moose/Util/TypeConstraints.pm b/lib/Moose/Util/TypeConstraints.pm index d361872..15c1220 100644 --- a/lib/Moose/Util/TypeConstraints.pm +++ b/lib/Moose/Util/TypeConstraints.pm @@ -398,7 +398,7 @@ sub _create_type_constraint ($$$;$$) { ) { ## creating the child is a job we delegate to the parent, since each ## parent may have local customization needs to influence it's child. - $constraint = $parent->create_childtype(%opts); + $constraint = $parent->create_child_type(%opts); } else { ## If for some reason the above couldn't create a type constraint, let's ## make sure to create something.