From: Nicholas Clark <nick@ccl4.org>
Date: Fri, 17 Apr 2009 09:15:42 +0000 (+0100)
Subject: In autodoc.pl, remove the unused parameters and functionality from walk_table().
X-Git-Url: http://git.shadowcat.co.uk/gitweb/gitweb.cgi?a=commitdiff_plain;h=848ad75c717886b27932509687e0ca4b7eef020a;p=p5sagit%2Fp5-mst-13.2.git

In autodoc.pl, remove the unused parameters and functionality from walk_table().
It seems that walk_table() was a direct copy from embed.pl back when autodoc.pl
was created by commit 94bdecf9800c3bee967274854f7adf2933ffd42b, and the "bonus
bits" were never refactored out.
---

diff --git a/autodoc.pl b/autodoc.pl
index 25fabf0..0e8258f 100644
--- a/autodoc.pl
+++ b/autodoc.pl
@@ -23,21 +23,6 @@ open IN, "embed.fnc" or die $!;
 # subroutine, printing the result
 sub walk_table (&@) {
     my $function = shift;
-    my $filename = shift || '-';
-    my $leader = shift;
-    my $trailer = shift;
-    my $F;
-    local *F;
-    if (ref $filename) {	# filehandle
-	$F = $filename;
-    }
-    else {
-	safer_unlink $filename;
-	$F = safer_open($filename);
-	binmode F;
-	$F = \*F;
-    }
-    print $F $leader if $leader;
     seek IN, 0, 0;		# so we may restart
     while (<IN>) {
 	chomp;
@@ -55,11 +40,7 @@ sub walk_table (&@) {
 	    @args = split /\s*\|\s*/, $_;
 	}
 	s/\b(NN|NULLOK)\b\s+//g for @args;
-	print $F $function->(@args);
-    }
-    print $F $trailer if $trailer;
-    unless (ref $filename) {
-	close $F or die "Error closing $filename: $!";
+	$function->(@args);
     }
 }
 
@@ -208,8 +189,7 @@ walk_table {	# load documented functions into appropriate hash
 	    warn "no docs for $func\n" unless $seenfuncs{$func};
 	}
     }
-    return "";
-} $doc;
+};
 
 for (sort keys %docfuncs) {
     # Have you used a full for apidoc or just a func name?