From: Nicholas Clark <nick@ccl4.org>
Date: Mon, 31 Oct 2005 18:29:05 +0000 (+0000)
Subject: Add "moving common filetest code to a static function" to the todo.
X-Git-Url: http://git.shadowcat.co.uk/gitweb/gitweb.cgi?a=commitdiff_plain;h=836ede62bb86a610a76a79ff480e4916d1c82de1;p=p5sagit%2Fp5-mst-13.2.git

Add "moving common filetest code to a static function" to the todo.

p4raw-id: //depot/perl@25936
---

diff --git a/pod/perltodo.pod b/pod/perltodo.pod
index 7de5353..59ca063 100644
--- a/pod/perltodo.pod
+++ b/pod/perltodo.pod
@@ -366,6 +366,14 @@ typically requiring 4 byte alignment, and then an odd C<bool> later on.
 to review the ordering of the variables, to see how much alignment padding can
 be removed.
 
+=head2 repeated code in filetest operators
+
+F<pp_sys.c> has a lot of partially repeated code in the filetest operators (for
+example C<pp_ftrowned>, C<pp_ftzero>, C<pp_ftsize>, and C<pp_ftmtime>,
+C<pp_ftatime>, C<pp_ftctime>). It would be good to investigate whether some
+of this could be refactored out into common static functions. A similar
+refactoring on F<utf8.c> saved about 1.5K of object code size.
+
 =head2 bincompat functions
 
 There are lots of functions which are retained for binary compatibility.